-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gRPC): client implementation #3280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3280 +/- ##
==========================================
+ Coverage 30.46% 31.89% +1.43%
==========================================
Files 143 146 +3
Lines 11834 12007 +173
Branches 1950 1974 +24
==========================================
+ Hits 3605 3830 +225
+ Misses 7985 7910 -75
- Partials 244 267 +23
|
aarnphm
force-pushed
the
feat/grpc-client
branch
7 times, most recently
from
November 28, 2022 11:33
aca74f0
to
87b9122
Compare
aarnphm
requested review from
bojiang and
sauyon
and removed request for
a team
November 28, 2022 11:57
aarnphm
force-pushed
the
feat/grpc-client
branch
5 times, most recently
from
November 29, 2022 06:19
b2e45a7
to
f5eda45
Compare
aarnphm
force-pushed
the
feat/grpc-client
branch
6 times, most recently
from
December 9, 2022 05:30
ddd553a
to
94f218d
Compare
aarnphm
commented
Dec 10, 2022
Closed
aarnphm
force-pushed
the
feat/grpc-client
branch
from
December 27, 2022 06:28
756e36e
to
0061adf
Compare
aarnphm
force-pushed
the
feat/grpc-client
branch
2 times, most recently
from
January 6, 2023 20:47
8a24913
to
518ebd6
Compare
Signed-off-by: Aaron Pham <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
reverted changes: pyproject.toml Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
aarnphm
force-pushed
the
feat/grpc-client
branch
from
January 11, 2023 20:40
e9adfa3
to
9d7e65c
Compare
Signed-off-by: Aaron Pham <[email protected]>
5 tasks
sauyon
reviewed
Jan 18, 2023
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
reverted changes: src/bentoml/_internal/server/grpc/servicer/v1/__init__.py Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
sauyon
requested changes
Feb 19, 2023
Co-authored-by: Sauyon Lee <[email protected]>
Signed-off-by: Aaron <[email protected]>
sauyon
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think this one has gone on long enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Pham [email protected]
Depends on #3278
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.