Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gRPC): client implementation #3280

Merged
merged 21 commits into from
Feb 23, 2023
Merged

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Nov 26, 2022

Signed-off-by: Aaron Pham [email protected]

Depends on #3278

What does this PR address?

Fixes #(issue)

Before submitting:

@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #3280 (8a6ba60) into main (e5af0c3) will increase coverage by 1.43%.
The diff coverage is 51.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3280      +/-   ##
==========================================
+ Coverage   30.46%   31.89%   +1.43%     
==========================================
  Files         143      146       +3     
  Lines       11834    12007     +173     
  Branches     1950     1974      +24     
==========================================
+ Hits         3605     3830     +225     
+ Misses       7985     7910      -75     
- Partials      244      267      +23     
Impacted Files Coverage Δ
src/bentoml/_internal/server/server.py 0.00% <0.00%> (ø)
src/bentoml/_internal/client/http.py 35.10% <35.10%> (ø)
src/bentoml/_internal/server/grpc_app.py 28.40% <50.00%> (+28.40%) ⬆️
src/bentoml/_internal/client/__init__.py 51.31% <51.31%> (ø)
src/bentoml/_internal/client/grpc.py 64.86% <64.86%> (ø)
src/bentoml/client.py 100.00% <100.00%> (+100.00%) ⬆️
src/bentoml/_internal/io_descriptors/file.py 42.85% <0.00%> (+0.68%) ⬆️
src/bentoml/_internal/io_descriptors/numpy.py 42.99% <0.00%> (+0.93%) ⬆️
src/bentoml/_internal/io_descriptors/pandas.py 40.55% <0.00%> (+1.11%) ⬆️
src/bentoml/_internal/service/inference_api.py 55.55% <0.00%> (+1.23%) ⬆️
... and 7 more

@aarnphm aarnphm force-pushed the feat/grpc-client branch 7 times, most recently from aca74f0 to 87b9122 Compare November 28, 2022 11:33
@aarnphm aarnphm marked this pull request as ready for review November 28, 2022 11:57
@aarnphm aarnphm requested a review from a team as a code owner November 28, 2022 11:57
@aarnphm aarnphm requested review from bojiang and sauyon and removed request for a team November 28, 2022 11:57
@aarnphm aarnphm force-pushed the feat/grpc-client branch 5 times, most recently from b2e45a7 to f5eda45 Compare November 29, 2022 06:19
@aarnphm aarnphm force-pushed the feat/grpc-client branch 6 times, most recently from ddd553a to 94f218d Compare December 9, 2022 05:30
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
grpc-client/python/client.py Outdated Show resolved Hide resolved
grpc-client/python/client.py Outdated Show resolved Hide resolved
src/bentoml/_internal/io_descriptors/base.py Outdated Show resolved Hide resolved
src/bentoml/_internal/io_descriptors/json.py Outdated Show resolved Hide resolved
src/bentoml/_internal/io_descriptors/json.py Outdated Show resolved Hide resolved
src/bentoml/client/__init__.py Outdated Show resolved Hide resolved
src/bentoml/client/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: Aaron Pham <[email protected]>
reverted changes: src/bentoml/_internal/server/grpc/servicer/v1/__init__.py

Signed-off-by: Aaron Pham <[email protected]>
src/bentoml/client.py Outdated Show resolved Hide resolved
src/bentoml/_internal/client/__init__.py Outdated Show resolved Hide resolved
src/bentoml/_internal/client/__init__.py Show resolved Hide resolved
src/bentoml/grpc/v1/service.proto Show resolved Hide resolved
@aarnphm aarnphm requested a review from sauyon February 23, 2023 05:54
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think this one has gone on long enough.

@sauyon sauyon enabled auto-merge (squash) February 23, 2023 07:49
@sauyon sauyon merged commit 10f2c39 into bentoml:main Feb 23, 2023
@aarnphm aarnphm deleted the feat/grpc-client branch February 23, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants