-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to node 14 #2367
chore: update to node 14 #2367
Conversation
SonarCloud Quality Gate failed. 8 Bugs No Coverage information |
You must modify the readme.md file too, the development paragraph states to use Node 10. |
This should be done in unison with the same update in https://github.com/betaflight/blackbox-log-viewer, as they are normally released together. |
@chmelevskij testing now. I have to update the Ubuntu and Fedora dev docs for this. Apart from updating nodejs on our machines - is there any other requirement for using this? |
@haslinghuis don't think so |
Kudos, SonarCloud Quality Gate passed! |
Looks like |
For some reason the Windows and Linux builds are failing with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the optional-dependencies are ok (it fails with a simple warning), but the resolutions not. It includes it for all. |
Yeah, will have to look into this. Might just fork the package which is causing headache and bring it up to node 14 deps |
@chmelevskij - I can do the documentation if you like. Anything else to make this work? |
Current show stopper is https://github.com/aluxian/gulp-appdmg , I've tried forking it and upgrading the packages, but then we need to upgrade gulp version as well. So it's a bit of a cascading issue at the moment. |
Want to know all domino's here, we must go forward, but guess it's about the
|
@chmelevskij Installed Fedora 34 and found out |
AUTOMERGE: (FAIL)
|
The 9e395ab build seems to run normally on Mac OSX. |
Tested on Windows 10. |
@chmelevskij LGTM! Can you please squash commits? |
Added link to .nvmrc
which has up to date version
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @chmelevskij
@McGiverGim could you please give a final look and merge? THanks! |
Update to node 14. Also added
appdmg
to the latest resolutions to which uses latestsfs-xattr
which works on 14