Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to node 14 #2367

Merged
merged 2 commits into from
Dec 20, 2021
Merged

chore: update to node 14 #2367

merged 2 commits into from
Dec 20, 2021

Conversation

chmelevskij
Copy link
Member

Update to node 14. Also added appdmg to the latest resolutions to which uses latests fs-xattr which works on 14

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 1, 2021

SonarCloud Quality Gate failed.

Bug C 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 663 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@McGiverGim
Copy link
Member

You must modify the readme.md file too, the development paragraph states to use Node 10.

@mikeller
Copy link
Member

mikeller commented Jan 1, 2021

This should be done in unison with the same update in https://github.com/betaflight/blackbox-log-viewer, as they are normally released together.

@chmelevskij chmelevskij marked this pull request as ready for review January 27, 2021 15:38
@chmelevskij
Copy link
Member Author

@haslinghuis
Copy link
Member

haslinghuis commented Feb 6, 2021

@chmelevskij testing now.

I have to update the Ubuntu and Fedora dev docs for this. Apart from updating nodejs on our machines - is there any other requirement for using this?

@chmelevskij
Copy link
Member Author

@haslinghuis don't think so

.travis.yml Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

.travis.yml Show resolved Hide resolved
@chmelevskij
Copy link
Member Author

Looks like yarn doesn't like resolutions and optionalDependencies 😞 Unless people are happy to always use --ignore-optional which is not the most pleasant experience (if you are on windows or linux though)

mikeller
mikeller previously approved these changes Feb 9, 2021
@mikeller
Copy link
Member

mikeller commented Feb 9, 2021

For some reason the Windows and Linux builds are failing with this.

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I continue thinking you need to change the README.md file in this PR.

image

@McGiverGim
Copy link
Member

For some reason the Windows and Linux builds are failing with this.

It seems the optional-dependencies are ok (it fails with a simple warning), but the resolutions not. It includes it for all.

@chmelevskij
Copy link
Member Author

Yeah, will have to look into this. Might just fork the package which is causing headache and bring it up to node 14 deps

@haslinghuis
Copy link
Member

@chmelevskij - I can do the documentation if you like. Anything else to make this work?

@chmelevskij
Copy link
Member Author

Current show stopper is https://github.com/aluxian/gulp-appdmg , I've tried forking it and upgrading the packages, but then we need to upgrade gulp version as well. So it's a bit of a cascading issue at the moment.

@haslinghuis
Copy link
Member

haslinghuis commented Jun 19, 2021

Want to know all domino's here, we must go forward, but guess it's about the cli version? Do we have to update the gulp script?

[mark@localhost betaflight-configurator]$ gulp --version
CLI version: 2.3.0
Local version: 4.0.2

@haslinghuis
Copy link
Member

haslinghuis commented Jun 26, 2021

@chmelevskij Installed Fedora 34 and found out appdmg is an OSX package. Did you try to update gulp as well?
Tried npm install -g appdmg

@blckmn
Copy link
Member

blckmn commented Dec 14, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

README.md Show resolved Hide resolved
haslinghuis
haslinghuis previously approved these changes Dec 16, 2021
@ctzsnooze
Copy link
Member

ctzsnooze commented Dec 17, 2021

The 9e395ab build seems to run normally on Mac OSX.

@haslinghuis
Copy link
Member

Tested on Windows 10.

@haslinghuis
Copy link
Member

@chmelevskij LGTM! Can you please squash commits?

haslinghuis
haslinghuis previously approved these changes Dec 17, 2021
@chmelevskij chmelevskij dismissed McGiverGim’s stale review December 19, 2021 06:30

Added link to .nvmrc which has up to date version

.nvmrc Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @chmelevskij

@asizon asizon linked an issue Dec 19, 2021 that may be closed by this pull request
@limonspb
Copy link
Member

@McGiverGim could you please give a final look and merge? THanks!

@limonspb limonspb self-requested a review December 20, 2021 06:20
@ctzsnooze ctzsnooze merged commit 6737c56 into betaflight:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Version 10 reached end of life on April 30th 2021
8 participants