-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use node 14 #495
chore: use node 14 #495
Conversation
d667621
to
8304b0a
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested if video playback is working with the new node version? This is often the sticky point for version compatibility with blackbox explorer, as external codecs are used.
I've tested it under Windows and it seems video playback works. I'm not totally sure because it is not too smooth but I think this happens too with older version. |
@chmelevskij please rebase. I think this should be merged soon to be in sync with configurator. |
@chmelevskij it would be great to action this - any chance you could review the conflicts and re-check it is OK? |
Hey, will try over the weekend. Want ot match the setup with configurator first. |
Updated with changes from configurator still need to verify the builds though. |
@chmelevskij it's not building. Any update on this? |
@chmelevskij seems some commits don't belong here? |
Kudos, SonarCloud Quality Gate passed! |
AUTOMERGE: (FAIL)
|
This is matching PR to use node 14 similar to how it's done in configurator. This also adds
.nvmrc
andengines
to match the configurator.