Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Baro debug #604

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Update Baro debug #604

merged 1 commit into from
Oct 25, 2022

Conversation

haslinghuis
Copy link
Member

Updates Baro debug changed in betaflight/betaflight#11911

@haslinghuis haslinghuis added this to the 3.7.0 milestone Oct 21, 2022
@haslinghuis haslinghuis self-assigned this Oct 21, 2022
@github-actions

This comment has been minimized.

Sign in to view
@KarateBrot
Copy link
Member

KarateBrot commented Oct 21, 2022 •
edited
Loading

Dang, that was fast 🚀

But I think we still need to adjust the units for the debug channels.

channel 0

  • no unit
  • Scaling: x1

channel 1

  • Unit: "hPa"
  • Scaling: x1

channel 2

  • Unit: "°C"
  • Scaling: x0.01

channel 3

  • Unit: "m"
  • Scaling: x0.01

@github-actions

This comment has been minimized.

Sign in to view
KarateBrot
KarateBrot requested changes Oct 21, 2022
View reviewed changes
js/flightlog_fields_presenter.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Oct 22, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@betaflight betaflight deleted a comment from github-actions bot Oct 22, 2022
@betaflight betaflight deleted a comment from github-actions bot Oct 22, 2022
@blckmn blckmn merged commit 52e7777 into betaflight:master Oct 25, 2022
@haslinghuis haslinghuis deleted the update-baro-debug branch October 25, 2022 11:06
@ctzsnooze ctzsnooze mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarateBrot KarateBrot KarateBrot approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
needs coordination with betaflight Ready to merge RN: IMPROVEMENT
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @KarateBrot @blckmn