Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore lost debug names, update DOP graphics scaling #608

Closed
wants to merge 1 commit into from

Conversation

ctzsnooze
Copy link
Member

I found that debugs after ATTITUDE would not display properly. I don't know the exact cause, but adding one extra line to the debug name list solves the problem.

If there is a better fix, please let me know.

Also modified the new GPS_DOP debug graphics to have a fixed amplitude scale, to make comparisons between DOP values easier.

I think the new GPS_DOP and MSP_VTX can appear in the 'normal' place and don't need a 'splice' until modified.

Found and fixed a BaroAlt that should have been baroAlt.

@github-actions

This comment has been minimized.

@McGiverGim
Copy link
Member

I don't know if this is the culprit, but here:

if (semver.gte(firmwareVersion, '4.2.0')) {
DEBUG_MODE.splice(DEBUG_MODE.indexOf('FF_INTERPOLATED'), 1);
}
if (semver.gte(firmwareVersion, '4.3.0')) {
DEBUG_MODE.splice(DEBUG_MODE.indexOf('FF_INTERPOLATED'), 1, 'FEEDFORWARD');

We remove the FF_INTERPOLATED if 4.2 or bigger, but we try to "rename" for 4.3 or bigger. I suppose that we need to "insert" and not "rename" for 4.3.

@ctzsnooze
Copy link
Member Author

ctzsnooze commented Nov 23, 2022

OK I fixed that, by adding back FEEDFORWARD, which was being added at the end of the array, because there was no index for FF_INTERPOLATED.

The real problem was the multiple new splice commands in PR #607. These were removing a whole lot entries for many current debug modes from the DEBUG_MODE list.

Reversing those changes restored the debug mode. I checked with multiple logs with different debug modes, and each debug mode now loads correctly, including the GPS_DOP debug.

If the intent of PR #604 was to identify or group new DEBUG_MODE lines as they arrive with new firmware versions, then the splice command should have been configured as an insert command, not a delete (cut) command, or maybe we just push to the end of the array?

@blckmn
Copy link
Member

blckmn commented Nov 23, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
42.4% 42.4% Duplication

@ctzsnooze ctzsnooze changed the title display newer debug names, update DOP graphics restore lost debug names, update DOP graphics scaling Nov 23, 2022
@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze ctzsnooze closed this Nov 23, 2022
@ctzsnooze
Copy link
Member Author

Closing since replaced by #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants