-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore lost debug names, update DOP graphics scaling #608
Conversation
This comment has been minimized.
This comment has been minimized.
I don't know if this is the culprit, but here: blackbox-log-viewer/js/flightlog_fielddefs.js Lines 544 to 548 in 4b20639
We remove the FF_INTERPOLATED if 4.2 or bigger, but we try to "rename" for 4.3 or bigger. I suppose that we need to "insert" and not "rename" for 4.3.
|
OK I fixed that, by adding back The real problem was the multiple new splice commands in PR #607. These were removing a whole lot entries for many current debug modes from the Reversing those changes restored the debug mode. I checked with multiple logs with different debug modes, and each debug mode now loads correctly, including the If the intent of PR #604 was to identify or group new |
AUTOMERGE: (FAIL)
|
bef2e87
to
1fa7f45
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Do you want to test this code? Here you have an automated build: |
Closing since replaced by #609 |
I found that debugs after
ATTITUDE
would not display properly. I don't know the exact cause, but adding one extra line to the debug name list solves the problem.If there is a better fix, please let me know.
Also modified the new GPS_DOP debug graphics to have a fixed amplitude scale, to make comparisons between DOP values easier.
I think the new GPS_DOP and MSP_VTX can appear in the 'normal' place and don't need a 'splice' until modified.
Found and fixed a BaroAlt that should have been baroAlt.