monitoring: mount service account token for grafana dashboard sidecar #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the kube-prometheus upgrade in #65, Grafana broke because the k8s-sidecar container that loads custom dashboards needs access to the service account token. That access was removed in prometheus-operator/kube-prometheus#1591 . A quick search did not turn up a simple way to only mount the token in one of the pod's containers (`k8s-sidecar`, not `grafana`), so we're mounting it for all containers in the pod instead. Might be possible to tighten this up further.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the kube-prometheus upgrade in #65, Grafana broke because the k8s-sidecar container that loads custom dashboards needs access to the service account token. That access was removed in prometheus-operator/kube-prometheus#1591 .
A quick search did not turn up a simple way to only mount the token in one of the pod's containers (
k8s-sidecar, notgrafana), so we're mounting it for all containers in the pod instead. Might be possible to tighten this up further.