disable injecting unnecessary variables allowing access to k8s API #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
commented
Jan 21, 2022
| @@ -98,6 +98,7 @@ function(params) { | |||
| apiVersion: 'v1', | |||
| kind: 'ServiceAccount', | |||
| metadata: p._metadata, | |||
| automountServiceAccountToken: false, | |||
There was a problem hiding this comment.
This part can be treated as a breaking change for folks who are using prometheus-operator in versions that do not have change from prometheus-operator/prometheus-operator#4514. Do you think we should wait with this until we have a new operator version and then circle back?
There was a problem hiding this comment.
Just out of curiosity, what is the next release date?
paulfantom
force-pushed
the
automountServiceAccountToken
branch
from
7f58166 to
2d077a0
Compare
|
rebased |
paulfantom
force-pushed
the
automountServiceAccountToken
branch
5 times, most recently
from
b9c3de4 to
648a675
Compare
paulfantom
force-pushed
the
automountServiceAccountToken
branch
from
648a675 to
8cb6979
Compare
philipgough
approved these changes
Feb 4, 2022
ArthurSens
approved these changes
Feb 5, 2022
bfritz
added a commit
to bfritz/homelab-apps
that referenced
this pull request
Feb 7, 2022
After the kube-prometheus upgrade in #65, Grafana broke because the k8s-sidecar container that loads custom dashboards needs access to the service account token. That access was removed in prometheus-operator/kube-prometheus#1591 . A quick search did not turn up a simple way to only mount the token in one of the pod's containers (`k8s-sidecar`, not `grafana`), so we're mounting it for all containers in the pod instead. Might be possible to tighten this up further.
bors bot
added a commit
to bfritz/homelab-apps
that referenced
this pull request
Feb 7, 2022
66: monitoring: mount service account token for grafana dashboard sidecar r=bfritz a=bfritz After the kube-prometheus upgrade in #65, Grafana broke because the k8s-sidecar container that loads custom dashboards needs access to the service account token. That access was removed in prometheus-operator/kube-prometheus#1591 . A quick search did not turn up a simple way to only mount the token in one of the pod's containers (`k8s-sidecar`, not `grafana`), so we're mounting it for all containers in the pod instead. Might be possible to tighten this up further. Co-authored-by: Brad Fritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
This will explicitly specify which applications need SA token and which do not need it.
Due to how prometheus server is managed, this PR requires prometheus-operator/prometheus-operator#4514 to be merged first.
This is a part of #1589
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.