Skip to content

Commit

Permalink
mozilla#186: Enable price polling in certain privacy contexts
Browse files Browse the repository at this point in the history
Previously, price polling (a.k.a. background price updates) was disabled when Do Not Track, Tracking Protection or certain cookie settings ('reject_third_party' and 'reject_all') were enabled.

Now, price polling occurs in these situations. This leaves the `shouldUpdatePrices` function in `privacy.js` kind of useless, but I left it there instead of removing it entirely in order to add the Private Browsing check that is part of mozilla#177.
  • Loading branch information
biancadanforth committed Nov 14, 2018
1 parent be6588e commit 7b76128
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions src/privacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,7 @@ export async function shouldCollectTelemetry(method) {
* @return {boolean}
*/
export async function shouldUpdatePrices() {
if (await trackingProtectionEnabled()) {
return false;
}

if (doNotTrackEnabled()) {
return false;
}

if (await cookiesBlocked()) {
return false;
}

// TODO (bdanforth): Add private browsing check per #177
return true;
}

Expand Down

0 comments on commit 7b76128

Please sign in to comment.