Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Non-blocking: consider nuanced background price polling when PBM tabs exist #177

Closed
groovecoder opened this issue Oct 18, 2018 · 6 comments
Closed

Non-blocking: consider nuanced background price polling when PBM tabs exist #177

groovecoder opened this issue Oct 18, 2018 · 6 comments
Assignees
@biancadanforth
Milestone
Post-Launch Devel...

Comments

@groovecoder
Copy link
Member

This does not need to block release

#168 went a long way to addressing #72.

As discussed in the PR, there may be some additional (non-blocking) enhancements to make for PBM ...

we could disable background updates while a PBM tab is the active tab.

maybe disable background updates if there are only PBM windows/tabs open. (I.e., for users who select "Always use Private Browsing" or manually close all regular browsing windows)
@groovecoder groovecoder mentioned this issue Oct 18, 2018
Merged
@javaun
Copy link

javaun commented Oct 18, 2018

I like these enhancements a lot. We might even be able to simplify/combine them

@Osmose Osmose added the [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. label Oct 18, 2018
@Osmose
Copy link
Contributor

Osmose commented Oct 18, 2018

This does not need to block release

This is my favorite part of the issue

@groovecoder
Copy link
Member Author

I like these enhancements a lot.
This is my favorite part of the issue

What can I say? I'm a crowd-pleaser.

@muccimoz muccimoz added reserve-November milestone and removed [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. labels Oct 18, 2018
@muccimoz muccimoz added this to the November MVP milestone Oct 18, 2018
@biancadanforth biancadanforth mentioned this issue Oct 19, 2018
Closed
1 task
@muccimoz muccimoz removed this from the November MVP milestone Nov 8, 2018
@biancadanforth biancadanforth mentioned this issue Nov 14, 2018
Closed
biancadanforth added a commit to biancadanforth/price-tracker that referenced this issue Nov 14, 2018
@biancadanforth
mozilla#186: Enable price polling in certain privacy contexts
7b76128 
Previously, price polling (a.k.a. background price updates) was disabled when Do Not Track, Tracking Protection or certain cookie settings ('reject_third_party' and 'reject_all') were enabled.

Now, price polling occurs in these situations. This leaves the `shouldUpdatePrices` function in `privacy.js` kind of useless, but I left it there instead of removing it entirely in order to add the Private Browsing check that is part of mozilla#177.
@chuckharmston
Copy link

@muccimoz how disruptive would it be to bring this in to the post-launch milestone?

@muccimoz muccimoz added the [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. label Nov 15, 2018
@muccimoz
Copy link
Collaborator

@muccimoz how disruptive would it be to bring this in to the post-launch milestone?

Hi Chuck. We can review this issue during triage at the team meeting today.

@muccimoz muccimoz removed the [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. label Nov 15, 2018
@muccimoz muccimoz added this to the Post-Launch Development-1 milestone Nov 15, 2018
@muccimoz
Copy link
Collaborator

@muccimoz how disruptive would it be to bring this in to the post-launch milestone?

Hi Chuck. This has been added to the milestone.

biancadanforth added a commit to biancadanforth/price-tracker that referenced this issue Nov 15, 2018
@biancadanforth
Fix mozilla#186: Enable price polling in certain privacy contexts
4ea7eed 
Previously, price polling (a.k.a. background price updates) was disabled when Do Not Track, Tracking Protection or certain cookie settings ('reject_third_party' and 'reject_all') were enabled.

Now, price polling occurs in these situations. This leaves the `shouldUpdatePrices` function in `privacy.js` kind of useless, but I left it there instead of removing it entirely in order to add the Private Browsing check that is part of mozilla#177.
@biancadanforth biancadanforth mentioned this issue Nov 15, 2018
Merged
@biancadanforth biancadanforth self-assigned this Nov 16, 2018
biancadanforth added a commit to biancadanforth/price-tracker that referenced this issue Nov 16, 2018
@biancadanforth
Fix mozilla#177: Disable price polling in Private Browsing windows
102331f 
Update `shouldUpdatePrices` with a check for whether or not the active window is a private window.

I did not add a check for `isActiveWindowPrivate` in `shouldExtract` in `./src/privacy.js`, despite the fact that `browser.extension.inIncognitoContext` returns the "wrong" value for background extraction, because background extraction is gated by the `shouldUpdatePrices` check.
biancadanforth added a commit to biancadanforth/price-tracker that referenced this issue Nov 20, 2018
@biancadanforth
Fix mozilla#177: Disable price polling in Private Browsing windows
6da5218 
Update `shouldUpdatePrices` with a check for whether or not the active window is a private window.

I did not add a check for `isActiveWindowPrivate` in `shouldExtract` in `./src/privacy.js`, despite the fact that `browser.extension.inIncognitoContext` returns the "wrong" value for background extraction, because background extraction is gated by the `shouldUpdatePrices` check.
biancadanforth added a commit that referenced this issue Nov 21, 2018
@biancadanforth
Merge pull request #276 from biancadanforth/177-pb-price-polling
3ede0bb 
Fix #177: Disable price polling in Private Browsing windows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@biancadanforth biancadanforth

Labels
None yet
Projects
None yet
Milestone
Post-Launch Development-1
Development

No branches or pull requests
6 participants
@chuckharmston @groovecoder @javaun @Osmose @biancadanforth @muccimoz