Improve readDir tests and fix harmonizeRelativePath for Windows #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readDir should be the unit tests, readDir-examples are integration.
rwblair
approved these changes
Aug 7, 2019
|
@sappelhoff can you try this branch to confirm it fixes issues on your end? |
|
Unfortunately it does not yet fix things: mne-tools/mne-bids#254 See the Appveyor Log This is how I install @nellh's branch:
|
|
Just tested on a windows 10 VM using 10.16.1 against ds000005 and am seeing the same issue. Confirmed that it worked on linux w/10.16.1. |
|
I'm going to merge this and open one more PR with a fix for #814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional test coverage and documentation for readDir to cover some cases which may affect Windows behavior and fixes a few small bugs in the test suite (extra console logging).