[MRG] remove reliance on datasets.py module #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
changed the title
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=========================================
+ Coverage 97.72% 97.83% +0.1%
=========================================
Files 8 8
Lines 925 925
=========================================
+ Hits 904 905 +1
+ Misses 21 20 -1
Continue to review full report at Codecov.
|
sappelhoff
commented
Aug 13, 2019
|
Tell us when good to go. So far so good |
jasmainak
reviewed
Aug 13, 2019
sappelhoff
changed the title
|
rendered examples that I touched in this PR: ready for review @jasmainak @agramfort this is the first step prior to deprecating |
jasmainak
reviewed
Aug 14, 2019
jasmainak
reviewed
Aug 14, 2019
jasmainak
reviewed
Aug 14, 2019
agramfort
approved these changes
Aug 14, 2019
|
Thanks @sappelhoff ! |
dominikwelke
pushed a commit
to dominikwelke/mne-bids
that referenced
this pull request
Oct 29, 2019
* try nellh fix for windows bids validator * try new fix by @nellh * go back to bids-validator master: fixed for Windows * awscli dependency * do not use datasets.py function in cli test * use awscli in example * fix typo * add awscli as optional dependency in README * use awscli in convert group studies example * do not use awscli in renaming example * group studies example without awscli * remove mention of awscli * fix warning directive * revers ds000117 example changes * fix warning directive * fix the warning directive finally
dominikwelke
pushed a commit
to dominikwelke/mne-bids
that referenced
this pull request
Feb 7, 2020
* try nellh fix for windows bids validator * try new fix by @nellh * go back to bids-validator master: fixed for Windows * awscli dependency * do not use datasets.py function in cli test * use awscli in example * fix typo * add awscli as optional dependency in README * use awscli in convert group studies example * do not use awscli in renaming example * group studies example without awscli * remove mention of awscli * fix warning directive * revers ds000117 example changes * fix warning directive * fix the warning directive finally
dominikwelke
pushed a commit
to dominikwelke/mne-bids
that referenced
this pull request
Feb 7, 2020
* try nellh fix for windows bids validator * try new fix by @nellh * go back to bids-validator master: fixed for Windows * awscli dependency * do not use datasets.py function in cli test * use awscli in example * fix typo * add awscli as optional dependency in README * use awscli in convert group studies example * do not use awscli in renaming example * group studies example without awscli * remove mention of awscli * fix warning directive * revers ds000117 example changes * fix warning directive * fix the warning directive finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #249
This PR deprecates the datasets.py module.EDIT, this will be done in a separate PR.post prior edit
I will remove all imports and references to that module in the code and examples, and make it so that when a user imports from
datasets.py, they get a warning that this will be removed in mne-bids0.4.Or should I just go ahead and remove the module without a deprecation cycle? @jasmainak
This PR removes the dependency on the
mne_bids.datasetsmodule for:the group conversion example*edit: will be done in a different PRThe functionality of the
mne_bids.datasetsmodule is replaced mymne.datasets.This involved a revamp of the group conversion example --> Now it only needs 1.6GB instead of the >7GB while still showing the same ideaMerge checklist
Maintainer, please confirm the following before merging:
whats_new.rst is updated