This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Hotfix/missing sprite #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 10, 2018 14:40
# Conflicts: # assets/scripts/blocks.js # assets/scripts/bundle.js # assets/styles/app.css # assets/styles/gutenberg.css
# Conflicts: # src/styles/utils/mixins/_icon.scss
ampersarnie
approved these changes
Dec 10, 2018
jaymcp
suggested changes
Dec 10, 2018
jaymcp
suggested changes
Dec 10, 2018
There was a problem hiding this comment.
Apologies; could you also add the following to the .gitignore:
admin.js.map
blocks.js.map
bundle.js.map
style-editor.css.map
style.css.map
and remove the cached versions from git, please? I should have done this in #27.
Do we need images/bigbitecreative.svg & src/images/bigbitecreative.svg?
If not, could we remove them both, too?
Cheers!
jaymcp
approved these changes
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Proposed Changes
icon_svgmixin instead