Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algorithms docs formatting #1645

Closed
wants to merge 4 commits into from
Closed

Algorithms docs formatting #1645

wants to merge 4 commits into from

Conversation

gunjanbaid
Copy link
Contributor

See #1639 for discussion.

@coveralls
Copy link

coveralls commented Jul 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 83.961% when pulling fd214c0 on gunjanbaid:issue#1663 into c8a2202 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2290/
Test PASSed.

@coveralls
Copy link

coveralls commented Jul 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 83.961% when pulling 9a34773 on gunjanbaid:issue#1663 into c8a2202 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2291/
Test PASSed.

@fnothaft fnothaft mentioned this pull request Jul 27, 2017
Closed
fnothaft
fnothaft reviewed Jul 27, 2017
View reviewed changes
Copy link
Member

@fnothaft fnothaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why are we dropping the anchors here?

@gunjanbaid
Copy link
Contributor Author

Added anchor tags back based on related discussion in #1642

@coveralls
Copy link

coveralls commented Jul 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 83.961% when pulling b54511b on gunjanbaid:issue#1663 into c8a2202 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2299/
Test PASSed.

fnothaft
fnothaft requested changes Aug 2, 2017
View reviewed changes
Copy link
Member

@fnothaft fnothaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific changes to request, but this breaks the pandoc generated PDF. Let's hold off on this until we move to reStructuredText.

@gunjanbaid
Copy link
Contributor Author

Sounds good.

@heuermh heuermh modified the milestone: 0.23.0 Sep 1, 2017
@fnothaft fnothaft mentioned this pull request Dec 5, 2017
Merged
@heuermh
Copy link
Member

heuermh commented Dec 13, 2017

I believe these fixes were included in #1646. Please reopen if anything was missed.

@heuermh heuermh closed this Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnothaft fnothaft fnothaft requested changes

@devin-petersohn devin-petersohn devin-petersohn approved these changes

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@gunjanbaid @coveralls @AmplabJenkins @heuermh @fnothaft @devin-petersohn