Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement to filter by the produced_by information issue #545 #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhancement to filter by the produced_by information issue #545 #125

wants to merge 1 commit into from

Conversation

selewis
Copy link
Contributor

@selewis selewis commented Nov 16, 2017

Includes test as well. Motivated by need to only obtain orthologs called by PANTHER

@selewis selewis requested a review from cmungall November 16, 2017 22:27
@cmungall
Copy link
Contributor

@deepakunni3 can this be closed?

@deepakunni3
Copy link
Member

@cmungall I am not sure about this PR. But the approach taken to filter is not ideal.
I would say lets close this, and create a new issue for the use case - filtering by provided_by field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall Awaiting requested review from cmungall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selewis @cmungall @deepakunni3