Move escher to extras #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escher has very old dependencis such as Jinja2 < 3 which is breaking many other packages. Moving this to extras to allow using cameo with other packages.
|
I agree with the change but it requires implementing some try-except blocks (like in https://github.com/biosustain/cameo/blob/devel/cameo/flux_analysis/simulation.py#L486) because some modules import escher by default. I believe that https://github.com/biosustain/cameo/blob/devel/cameo/visualization/visualization.py and https://github.com/biosustain/cameo/blob/devel/cameo/strain_design/deterministic/flux_variability_based.py#L822 (the latter uses an import form escher_ext) are the culprits of the top-level imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escher has very old dependencis such as Jinja2 < 3 which is breaking many other packages. Moving this to extras to allow using cameo with other packages.