Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define variant node kinds #73

Closed
wants to merge 3 commits into from

Conversation

okjodom
Copy link
Collaborator

@okjodom okjodom commented Aug 22, 2023

Requires redefining config in the shape below

 "nodes": [
    {
      "LND": {
        "id": "",
        "address": "",
        "macaroon": "",
        "cert": ""
      }
    },
    {
      "CLN": {
        "id": "",
        "address": "",
        "ca_pem": "",
        "client_pem": "",
        "client_cert": "",
      }
    }
  ],
  "activities": []

@okjodom okjodom requested a review from sr-gi August 22, 2023 09:02
@okjodom okjodom marked this pull request as draft August 22, 2023 10:34
@okjodom okjodom force-pushed the node-kind branch 2 times, most recently from 4cd3c36 to 3232e16 Compare August 22, 2023 16:15
@carlaKC
Copy link
Contributor

carlaKC commented Aug 23, 2023

Requests from our warnet friends:

 "nodes": [
    {
        "impl": "LND",
        "id": "",
        "address": "",
        "macaroon": "",
        "cert": ""
  },
  {
        "impl": "CLN",
        "id": "",
        "address": "",
        "macaroon": "",
        "cert": ""
    },
  ],

@okjodom
Copy link
Collaborator Author

okjodom commented Aug 23, 2023

closed in favor of #74 and #75

@okjodom okjodom closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants