Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HostEnsureCanCompileStrings to the new spec #3690

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

jedel1043
Copy link
Member

PR tc39/ecma262#3222 introduced a new HostEnsureCanCompileStrings that passes the body and parameters of the runtime-compiled function for additional checks.

The regressions are because the test repo hasn't been updated with the new behaviour; on the old spec,
the parameters were converted to strings before the body, which is the opposite of what the new spec states.

@jedel1043 jedel1043 added test Issues and PRs related to the tests. API labels Feb 22, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Feb 22, 2024
@jedel1043 jedel1043 requested a review from a team February 22, 2024 04:58
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,549 42,547 -2
Ignored 1,570 1,570 0
Failed 6,149 6,151 +2
Panics 0 0 0
Conformance 84.64% 84.64% -0.00%
Broken tests (2):
test/built-ins/Function/S15.3.2.1_A3_T1.js (previously Passed)
test/built-ins/Function/S15.3.2.1_A3_T3.js (previously Passed)

@jedel1043
Copy link
Member Author

jedel1043 commented Feb 22, 2024

Opened a PR on the test262 repo: tc39/test262#4013
Hopefully they'll take a look to that soon.

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also very nice refactor of create_dynamic_function.

I'm not sure if we want to wait for the discussion in tc39/test262#4013 to be resolved. Imo we can merge this and if needed adjust later.

@raskad raskad requested a review from a team February 22, 2024 19:47
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Agree with @raskad

@HalidOdat HalidOdat added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit c94e10d Feb 22, 2024
13 checks passed
@HalidOdat HalidOdat deleted the new-compile-string-checks branch February 22, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants