Normative: Restore params/body ToString order in new Function
#3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
normative change
bakkot
approved these changes
Feb 27, 2024
syg
approved these changes
Feb 28, 2024
syg
added
the
ready to merge
ljharb
force-pushed
the
new-function-stringify-body-after-params
branch
from
5c41895
to
ae080b8
Compare
ljharb
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3222 (cc @ptomato) accidentally changed the
new Functionimplementation to stringify the body before the parameters, rather than after. This change was introduced in this force-push to that PR, as part of the response to #3222 (comment), but it was unnecessary (and unrelated) for Kevin's request.Being accidental, this change was never discussed in plenary (slides, notes 1, notes 2). If anything, the slide that got consensus (slide 25) mentions that we "stringify the parameters and the body", and not the other way around.
The behavior restored by this PR is also tested by test262:
This bug was cought by @jedel1043, that already implemented it in Boa (boa-dev/boa#3690).
I marked this as normative, but I don't think it needs to go through plenary because it simply reverses a normative change that was never presented for consensus.