Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility of test suit with django 1.10 #212

Merged
merged 8 commits into from
Oct 24, 2016

Conversation

luzfcb
Copy link
Contributor

@luzfcb luzfcb commented Aug 16, 2016

  • fix compatibility of the test suit with django 1.10
  • use tox to run test suite on travis-ci

@luzfcb luzfcb changed the title add django 1.10 to travis-ci test matrix fix compatibility of test suit with django 1.10 Aug 29, 2016
@luzfcb
Copy link
Contributor Author

luzfcb commented Aug 29, 2016

@kennethlove tests fail with python3.2, because the last pip version that supports 3.2 is 7.1.2. I have not figured out how to force tox use another pip version in a specific test environment

update docs
add myself to CONTRIBUTORS.txt
@luzfcb
Copy link
Contributor Author

luzfcb commented Aug 30, 2016

@kennethlove Python 3.2 reached the End of Life on 2016-02-20 (https://docs.python.org/devguide/#status-of-python-branches) and django officially no longer supports any version <1.8 ( https://www.djangoproject.com/download/#supported-versions)

I believe it is viable to remove support for Python 3.2 and and perhaps django <1.8

@kennethlove
Copy link
Member

I'm OK with dropping support for Python 3.2 but earlier versions of Django are where django-braces is most useful, so I'd rather not drop support for them until/unless we have to.

@luzfcb
Copy link
Contributor Author

luzfcb commented Aug 31, 2016

@kennethlove i remove python 3.2 and all tests are now passing.
thank you for your hard work on this project.

@luzfcb
Copy link
Contributor Author

luzfcb commented Oct 20, 2016

@kennethlove ping

@kennethlove kennethlove merged commit 4e8a238 into brack3t:master Oct 24, 2016
@luzfcb
Copy link
Contributor Author

luzfcb commented Oct 24, 2016

@kennethlove 🙏 if not asking too much, could you mark this pull-request with the label "Hacktoberfest"

@luzfcb luzfcb deleted the patch-1 branch October 25, 2016 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants