Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Django 1.10 #703

Closed
7 of 12 tasks
luzfcb opened this issue Aug 1, 2016 · 41 comments
Closed
7 of 12 tasks

Update to Django 1.10 #703

luzfcb opened this issue Aug 1, 2016 · 41 comments

Comments

@luzfcb
Copy link
Collaborator

luzfcb commented Aug 1, 2016 •
edited
Loading

Checklist:

  • Before update to Django 1.10, create a git tag to current version of cookiecuter-django
  • Check if all dependencies officialy work with Django 1.10( if not, wait)
  • Check that the tests pass on Django 1.10
  • Check that the tests pass on Django 1.10 with zero deprecation warnings messages: https://docs.djangoproject.com/en/1.10/howto/upgrade-version/#resolving-deprecation-warnings
  • Update to Django 1.10 and update other dependencies and:
    • Check if all possible generated project layout still works on deploy on Heroku.
    • Check if all possible generated project layout still works on deploy on Docker.
    • Check PyCharm 2016.2 compatibility, with and widout docker
    • Update the README.rst
    • Update version on setup.py
    • Update changelog.
    • after update, create a git tag

related: #702
@ssteinerx
Copy link
Contributor

Generated layout works on Docker other than #704 opened 18 hours ago by ssteinerx

@ssteinerx
Copy link
Contributor

ssteinerx commented Aug 2, 2016 •
edited
Loading

Pycharm container also crashes immediately with no output other than exited with code 0.

#707

@audreyfeldroy
Copy link
Member

Verified that the tests pass on 1.10

@audreyfeldroy
Copy link
Member

audreyfeldroy commented Aug 2, 2016 •
edited by luzfcb
Loading

Dependencies that are Django version-dependent:

Check off each of the above when it officially works on 1.10.

@jayfk
Copy link
Collaborator

jayfk commented Aug 3, 2016

django-model-utils is not ready, see the latest change log in #709

@jayfk
Copy link
Collaborator

jayfk commented Aug 3, 2016

django-extensions is not ready, see django-extensions/django-extensions#934

@jayfk
Copy link
Collaborator

jayfk commented Aug 3, 2016

django-test-plus is not ready, see revsys/django-test-plus#45

@jayfk
Copy link
Collaborator

jayfk commented Aug 3, 2016

django-debug-toolbar is not ready, see django-commons/django-debug-toolbar#864

@luzfcb luzfcb mentioned this issue Aug 10, 2016
Closed
@pydanny
Copy link
Member

pydanny commented Aug 28, 2016

@jayfk, the following libraries are now ready and marked as such in the checklist:

  • django-model-utils
  • django-extensions
  • django-test-plus
  • django-debug-toolbar

@jayfk
Copy link
Collaborator

jayfk commented Aug 29, 2016

👍

@luzfcb
Copy link
Collaborator Author

luzfcb commented Aug 29, 2016 •
edited
Loading

django-braces test suite passes on Django 1.10
brack3t/django-braces#212

@luzfcb
Copy link
Collaborator Author

luzfcb commented Sep 6, 2016 •
edited
Loading

django-floppyforms still require a lot of work to run with Django 1.10

See travis-ci tests of this pull-request jazzband/django-floppyforms#178

@ssteinerx ssteinerx mentioned this issue Sep 6, 2016
Closed
@pydanny
Copy link
Member

pydanny commented Sep 6, 2016

@luzfcb Cookiecutter Django doesn't actually use django-floppyforms. We use it, sometimes. Perhaps it behooves us to remove it as a dependency?

@pydanny
Copy link
Member

pydanny commented Sep 6, 2016 •
edited
Loading

The following work with 1.10 and are marked as such on the checklist

  • factory-boy
  • django-storages-redux

pydanny added a commit that referenced this issue Sep 10, 2016
@pydanny
Removed floppyforms (see #703)
28542a9 
While this is an awesome package...

* Nothing in Cookiecutter Django uses it 
* Doesn't work with Django 1.10 yet
* Developers can add it themselves
@pydanny
Copy link
Member

pydanny commented Sep 10, 2016

Removed django-floppyforms in 28542a9

@ssteinerx
Copy link
Contributor

@audreyr Django extensions was updated 5 days ago and now says: Django Extensions requires Django 1.8 or later and one of the recent commits says "Add Django 1.10 trove classifier" so I think that can be checked off.

@ssteinerx
Copy link
Contributor

Django-redis is also passing this on all supported versions of Python:

@ssteinerx
Copy link
Contributor

IOW, cookiecutter-django for Django 1.10 is ready to rock vis-à-vis the dependency list!

@jayfk
Copy link
Collaborator

jayfk commented Sep 11, 2016

IOW, cookiecutter-django for Django 1.10 is ready to rock vis-à-vis the dependency list!

Apparently, django-coverage-plugin is not ready: nedbat/django_coverage_plugin#28

@ssteinerx
Copy link
Contributor

ssteinerx commented Sep 11, 2016 •
edited
Loading

@jayfk I actually spent a couple of hours today trying to figure out how to resolve
nedbat/django_coverage_plugin#28.

It's a very deep issue with the new template handlers and I've been away from Django long enough (last seriously involved circa 1.5ish) that while I understand the issue, I am completely unfamiliar with the changes that went in in 1.8 that completely break .django_coverage_plugin.

The long IRC discussion was interesting, enlightening in some ways, and left me completely clueless as to how to resolve the issue.

That it's been unresolved this long makes me think we should consider dropping the dependency and moving on. It's a "nice to have" but not the end of the world if it's not there and I, for one, am not willing to hang back a version indefinitely for this one thing, especially with Channels coming in soon...

@jayfk
Copy link
Collaborator

jayfk commented Sep 11, 2016

Good call. If this is a deeper issue, I'm in favor of dropping it for now (and watch it closely thereafter) to get 1.10 out of the door.

@ssteinerx
Copy link
Contributor

This is the killer issue: nedbat/django_coverage_plugin#26

Read the IRC chat, this is going to be a bear to untangle if it even ever gets done.

@ssteinerx
Copy link
Contributor

Is there a way to fake pyup-bot out into notifying us of a change on something we're not really depending on (so we don't have to remember to check, and will be notified as soon as django_coverage_plugin has a new release?)

If so, that makes it even easier to ditch it until it's resolved as we'll have a machine watching for changes and, if they never come, it'll consume zero human-cycles.

@jayfk
Copy link
Collaborator

jayfk commented Sep 11, 2016

We could pull it out of the main requirement files (so that it won't be installed) and place it in a separate file like requirements_to_watch.txt or something.

@ssteinerx
Copy link
Contributor

ssteinerx commented Sep 11, 2016 •
edited
Loading

@jayfk -- you have no idea how bad I just wanted to say "Make it So", tug on my shirt, and head back to my "Ready Room" to order some Tea, Earl Grey, hot ;-).

@luzfcb
Copy link
Collaborator Author

luzfcb commented Sep 11, 2016

We could pull it out of the main requirement files (so that it won't be installed) and place it in a separate file like requirements_to_watch.txt or something.

good, simple and will work.

@ssteinerx
Copy link
Contributor

@luzfcb What is pyup-bot's rule? If it begins with 'requirements`, its contents are added to the list of things to watch? If so, this'd be perfect!

@jayfk
Copy link
Collaborator

jayfk commented Sep 11, 2016

If it begins with 'requirements`, its contents are added to the list of things to watch? If so, this'd be perfect!

Exactly, done in #783.

Looks like we're ready, right?

@ssteinerx
Copy link
Contributor

Is the removal of React/WebPack merged into master yet? I thought I saw @pydanny do that the other day, but I wasn't paying attention to where it got merged to.

@ssteinerx
Copy link
Contributor

I think he merged master to the remove-react-for-now branch, but I don't think it was merged back the other way.

@luzfcb
Copy link
Collaborator Author

luzfcb commented Sep 11, 2016

@ssteinerx

@luzfcb What is pyup-bot's rule? If it begins with 'requirements`, its contents are added to the list of things to watch? If so, this'd be perfect!

the rules are documented in: https://pyup.io/docs/configuration/#requirement-file-search

@ssteinerx
Copy link
Contributor

@luzfcb Cool. Wasn't being lazy, would have looked it up if necessary, just knew someone here would know to make sure we let the machines do the work.

@jayfk
Copy link
Collaborator

jayfk commented Sep 11, 2016

@luzfcb I should hire you :)

@ssteinerx
Copy link
Contributor

I can help with this: Check PyCharm 2016.2 compatibility, with and widout docker if we've got a release candidate branch going...

@jayfk
Copy link
Collaborator

jayfk commented Sep 11, 2016

maybe we should continue the discussion on gitter as it gets pretty noisy for everyone not involved in the release process if we continue with this passion.

@ssteinerx
Copy link
Contributor

@jayfk agreed, I'll find the link and head there now.

@ssteinerx
Copy link
Contributor

https://gitter.im/pydanny/cookiecutter-django

@luzfcb luzfcb mentioned this issue Sep 15, 2016
Merged
10 tasks
@ameistad
Copy link
Contributor

I don't think raven (Sentry) is ready for 1.10 just yet.
getsentry/raven-python#858 and getsentry/raven-python#860

@jhancia
Copy link

jhancia commented Sep 20, 2016

I may be missing something, but it looks like django-storages-redux is "now released on PyPI as django-storages" as of 2-7-2016 (see https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst). So our requirements/production for this should now list django-storages==1.5.1

@luzfcb
Copy link
Collaborator Author

luzfcb commented Sep 20, 2016

@jhancia thank you, I really had not seen it.

@pydanny
Copy link
Member

pydanny commented Oct 7, 2016

Closing as resolved

@pydanny pydanny closed this as completed Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ssteinerx @pydanny @audreyfeldroy @luzfcb @jayfk @ameistad @jhancia