Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement needs browser update to see ads alerts. #13377

Merged
merged 3 commits into from
May 21, 2022
Merged

Implement needs browser update to see ads alerts. #13377

merged 3 commits into from
May 21, 2022

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented May 18, 2022 •
edited
Loading

Show need to update browser alert on NTP and on rewards settings page.

Resolves brave/brave-browser#21388

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@aseren aseren requested review from a team as code owners May 18, 2022 17:27
@aseren aseren requested review from bsclifton and zenparsing May 18, 2022 17:27
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels May 18, 2022
@aseren aseren requested a review from tmancey May 18, 2022 17:27
@aseren aseren force-pushed the issues/21388 branch 3 times, most recently from 815cd2f to 3344070 Compare May 19, 2022 11:49
@aseren
Copy link
Collaborator Author

aseren commented May 19, 2022

Desktop rewards page:
Screen Shot 2022-05-19 at 5 57 39 PM

NTP rewards widget:
Screen Shot 2022-05-19 at 5 57 52 PM

Android rewards page:
Screen Shot 2022-05-19 at 5 55 13 PM

zenparsing
zenparsing reviewed May 19, 2022
View reviewed changes
components/brave_rewards/resources/shared/components/newtab/rewards_card.tsx Outdated Show resolved Hide resolved
browser/brave_ads/ads_service_impl.h Outdated Show resolved Hide resolved
browser/ui/webui/brave_webui_source.cc Outdated Show resolved Hide resolved
browser/ui/webui/brave_webui_source.cc Outdated Show resolved Hide resolved
components/brave_new_tab_ui/reducers/new_tab_reducer.ts Outdated Show resolved Hide resolved
components/brave_new_tab_ui/storage/new_tab_storage.ts Outdated Show resolved Hide resolved
components/brave_rewards/resources/page/storage.ts Outdated Show resolved Hide resolved
components/brave_rewards/resources/shared/components/need_update_browser_alert_view.tsx Outdated Show resolved Hide resolved
components/resources/brave_components_strings.grd Outdated Show resolved Hide resolved
components/resources/brave_components_strings.grd Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@aseren aseren requested review from tmancey and zenparsing May 20, 2022 10:34
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

zenparsing
zenparsing approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great!

components/resources/brave_components_strings.grd Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@tmancey tmancey self-requested a review May 20, 2022 17:53
tmancey
tmancey approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aseren aseren changed the title Implement need to update browser to see ads alerts. Implement needs browser update to see ads alerts. May 20, 2022
@aseren aseren added this to the 1.41.x - Nightly milestone May 20, 2022
@aseren aseren merged commit 9137fa3 into master May 21, 2022
@aseren aseren deleted the issues/21388 branch May 21, 2022 06:24
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Jun 27, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

@zenparsing zenparsing zenparsing approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton bsclifton is a code owner automatically assigned from brave/rewards-client

Assignees

@aseren aseren

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging this pull request may close these issues.

Notify user if they need to update Brave in order for Ads to work
4 participants
@aseren @brave-builds @tmancey @zenparsing