Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elasticsearch] Bump version from 0.19.8 to 2.1.1 #552

Merged
merged 2 commits into from
Jan 6, 2016
Merged

[elasticsearch] Bump version from 0.19.8 to 2.1.1 #552

merged 2 commits into from
Jan 6, 2016

Conversation

magicbane
Copy link

Bumped elasticsearch version and fix multiple api changes.
update README.md troubleshoot section.

Previous issue:
./bin/ycsb run elasticsearch -s -P workloads/workloada
...
2015-12-24 02:19:55:472 4 sec: 1000 operations; 242.19 current ops/sec; [UPDATE-FAILED: Count=505, Max=15575, Min=93, Avg=286.22, 90=257, 99=2855, 99.9=9071, 99.99=15575] [READ: Count=0, Max=0, Min=9223372036854775807, Avg=�, 90=0, 99=0, 99.9=0, 99.99=0] [CLEANUP: Count=1, Max=87103, Min=87040, Avg=87072, 90=87103, 99=87103, 99.9=87103, 99.99=87103] [UPDATE: Count=0, Max=0, Min=9223372036854775807, Avg=�, 90=0, 99=0, 99.9=0, 99.99=0] [READ-FAILED: Count=495, Max=8615, Min=93, Avg=235.25, 90=243, 99=1975, 99.9=8615, 99.99=8615]
[OVERALL], RunTime(ms), 4139.0
[OVERALL], Throughput(ops/sec), 241.60425223483932
[UPDATE-FAILED], Operations, 505.0
[UPDATE-FAILED], AverageLatency(us), 286.21980198019804
[UPDATE-FAILED], MinLatency(us), 93.0
[UPDATE-FAILED], MaxLatency(us), 15575.0
[UPDATE-FAILED], 95thPercentileLatency(us), 369.0
[UPDATE-FAILED], 99thPercentileLatency(us), 2855.0
[READ], Operations, 0.0
[READ], AverageLatency(us), NaN
[READ], MinLatency(us), 9.223372036854776E18
[READ], MaxLatency(us), 0.0
[READ], 95thPercentileLatency(us), 0.0
[READ], 99thPercentileLatency(us), 0.0
[READ], Return=ERROR, 495
[CLEANUP], Operations, 1.0
[CLEANUP], AverageLatency(us), 87072.0
[CLEANUP], MinLatency(us), 87040.0
[CLEANUP], MaxLatency(us), 87103.0
[CLEANUP], 95thPercentileLatency(us), 87103.0
[CLEANUP], 99thPercentileLatency(us), 87103.0
[UPDATE], Operations, 0.0
[UPDATE], AverageLatency(us), NaN
[UPDATE], MinLatency(us), 9.223372036854776E18
[UPDATE], MaxLatency(us), 0.0
[UPDATE], 95thPercentileLatency(us), 0.0
[UPDATE], 99thPercentileLatency(us), 0.0
[UPDATE], Return=ERROR, 505
[READ-FAILED], Operations, 495.0
[READ-FAILED], AverageLatency(us), 235.24646464646466
[READ-FAILED], MinLatency(us), 93.0
[READ-FAILED], MaxLatency(us), 8615.0
[READ-FAILED], 95thPercentileLatency(us), 412.0
[READ-FAILED], 99thPercentileLatency(us), 1975.0
===
fixed:
[OVERALL], RunTime(ms), 38322.0
[OVERALL], Throughput(ops/sec), 26.094671468086215
[READ], Operations, 470.0
[READ], AverageLatency(us), 1238.4914893617022
[READ], MinLatency(us), 531.0
[READ], MaxLatency(us), 10071.0
[READ], 95thPercentileLatency(us), 2157.0
[READ], 99thPercentileLatency(us), 4247.0
[READ], Return=OK, 470
[CLEANUP], Operations, 1.0
[CLEANUP], AverageLatency(us), 240192.0
[CLEANUP], MinLatency(us), 240128.0
[CLEANUP], MaxLatency(us), 240255.0
[CLEANUP], 95thPercentileLatency(us), 240255.0
[CLEANUP], 99thPercentileLatency(us), 240255.0
[UPDATE], Operations, 530.0
[UPDATE], AverageLatency(us), 5101.537735849057
[UPDATE], MinLatency(us), 2204.0
[UPDATE], MaxLatency(us), 211199.0
[UPDATE], 95thPercentileLatency(us), 9447.0
[UPDATE], 99thPercentileLatency(us), 22383.0
[UPDATE], Return=OK, 530

[elasticsearch] Bump version from 0.19.8 to 2.1.1
54d443c 
Bumped elasticsearch version and fix multiple api changes.
update README.md troubleshoot section.
@busbey
Copy link
Collaborator

busbey commented Dec 24, 2015

What's the likelihood that folks would still want to compare to the older ES versions?

busbey
busbey reviewed Dec 24, 2015
View reviewed changes
elasticsearch/pom.xml
</properties>
<dependencies>
<dependency>
<groupId>net.java.dev.jna</groupId>
<artifactId>jna</artifactId>
<version>4.1.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is jna actually getting used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, elasticsearch supports jna, though it does have a fallback in case jna isn't supported.
I don't have a strong opinion on whether to keep it or not, so if you have a good reason to remove it I'm fine with that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, so the normal client dependency will use jna if it's present but won't bring it in?

Including it is fine by me; a comment here I'm the pom about why we need to expressly include it will help avoid having it refactored out in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes; I'll make a comment.

@magicbane
Copy link
Author

the current version of ES (0.19) benchmarking is broken anyway, so I bumped up the version to 2.x.
I doubt anyone would want to benchmark 0.19. It may be reasonable if someone would want to benchmark 1.x, but if we're fixing something, might as well bump it up to the latest stable version.

@busbey
Copy link
Collaborator

busbey commented Dec 25, 2015

The only reason I ask about benchmarking older versions is that often we have to then maintain two bindings in order to account for differences in what a client must do to talk to the different datastore versions (e.g. take a look at the Cassandra or HBase clients). If ES doesn't have to account for this or if folks don't still compare to 1.x, then I'm all for just bumping to latest.

I believe to figure this out for Cassandra we asked on the relevant user mailing list. Is there an equivalent for ES we could check?

@busbey busbey mentioned this pull request Dec 25, 2015
Closed
@magicbane
Copy link
Author

Hmm. Considering how outdated the ES branch is, my guess is no. I'm also not aware of any mailing list. Do you know who might know about it?

@busbey
Copy link
Collaborator

busbey commented Dec 31, 2015

When we have a release, we announce it in the Elastic Search forum on ecosystem projects:

https://discuss.elastic.co/c/ecosystem

@magicbane
Copy link
Author

https://discuss.elastic.co/t/ycsb-es-version-bump/38256

No one has chimed in yet.

@busbey
Copy link
Collaborator

busbey commented Jan 6, 2016

4 days is enough waiting for me.

busbey added a commit that referenced this pull request Jan 6, 2016
@busbey
Merge pull request #552 from magicbane/master
b25bd3a 
[elasticsearch] Bump version from 0.19.8 to 2.1.1
@busbey busbey merged commit b25bd3a into brianfrankcooper:master Jan 6, 2016
@busbey
Copy link
Collaborator

busbey commented Jan 6, 2016

Thanks for the contribution!

@magicbane magicbane mentioned this pull request Jan 6, 2016
Open
@risdenk risdenk mentioned this pull request Jan 22, 2016
Open
@risdenk risdenk mentioned this pull request Feb 15, 2016
Closed
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
@busbey
Merge pull request brianfrankcooper#552 from magicbane/master
6fe43c1 
[elasticsearch] Bump version from 0.19.8 to 2.1.1
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
@busbey
Merge pull request brianfrankcooper#552 from magicbane/master
7f67bf6 
[elasticsearch] Bump version from 0.19.8 to 2.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicbane @busbey @risdenk