Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es such as "List" rather than specific implementation classes such as "LinkedList"
|
This looks good to me. I'd like to merge #552 first, since I think this will cause that patch to fail to apply. |
|
We'll need to flag this as an incompatible change for datastore binding implementations. |
|
Please rebase for current master and update commit message for changed modules. Otherwise looks good. |
risdenk
requested changes
Nov 28, 2016
|
Would be awesome to update this. Its a simple change but affects a lot of files. |
|
@manolama - Here is an existing PR for what you were talking about going HashMap -> Map. |
|
Cleaned up and merged in cf5d2ca. I'll make a note about the signature change for binding implementors in the release notes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1319 - Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList"
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:S1319
Please let me know if you have any questions.
Kirill Vlasov