fix(rails): fix nil dereference in SQL Active Record bind
key
#565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Older versions of
mysql2
adapter do not contain thebind
key in the Active Record notification.Changeset
Changed
railtie.rb
- added extra guard for key not being present in notificationTests
I was unable to get a Rails instance with
mysql2
v0.3.x working to reproduce this issue. However I have run it with later versions to ensure that we pick up thebind
key correctly still (this is also checked on MazeRunner tests).Linked issues
Fixes #555
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: