Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rails): fix nil dereference in SQL Active Record bind key #565

Merged
merged 4 commits into from
Sep 3, 2019

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented Sep 2, 2019

Goal

Older versions of mysql2 adapter do not contain the bind key in the Active Record notification.

Changeset

Changed

  • railtie.rb - added extra guard for key not being present in notification

Tests

I was unable to get a Rails instance with mysql2 v0.3.x working to reproduce this issue. However I have run it with later versions to ensure that we pick up the bind key correctly still (this is also checked on MazeRunner tests).

Linked issues

Fixes #555

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

Older versions of `mysql2` adapter do not contain the `bind` key in the Active Record notification.
@tomlongridge tomlongridge force-pushed the tom/active-record-missing-binds-key branch from 0c63378 to b9b788c Compare September 2, 2019 12:46
@tomlongridge tomlongridge requested a review from tobyhs September 2, 2019 13:22
@tomlongridge tomlongridge marked this pull request as ready for review September 2, 2019 13:22
@tomlongridge tomlongridge changed the base branch from master to next September 2, 2019 13:25
Copy link
Contributor

@tobyhs tobyhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a wording suggestion, otherwise lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@tomlongridge tomlongridge merged commit 338bdaf into next Sep 3, 2019
@tomlongridge tomlongridge deleted the tom/active-record-missing-binds-key branch September 3, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants