-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed travis test failing for older versions of go #604
Conversation
.travis.yml
Outdated
script: | ||
- diff <(gofmt -d .) <(echo -n) | ||
- go vet -x ./... | ||
- golint -set_exit_status ./... | ||
- golint -set_exit_status ./... || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this ignore the result of golint now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, good point. I will see if I can do something regarding this. If you have a look at the conversation, it is simply a problem with older versions of go (since the function that is causing the error was introduced in v1.9)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think that this should be "optional" though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm happy for lint to not fail, I just want gofmt to be enforced, if we add a format check that would be fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking to add a bash script with this regex for go version: go[1-9].[1-9]?[0-9].[0-9]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will have to be updated upon version update though...
Thank you so much! |
* Fixed travis test failing for older versions of go * changed supported go version
Older versions of go were making tests fail due to golint.
Post v1.6 of go, golint changed to an official repo.
Error before change:
pre v1.9, this method was not present.
References: