-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for golang linter install failing during docker image build #52
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it |
CLAs look good, thanks! |
This PR (HEAD: 72bfe77) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/143541 to see it. Tip: You can toggle comments from me using the |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/143541. |
Message from Gerrit User 24096: Patch Set 1: Should we do this ? Considering we only support 1.10 and 1.11 right now. Please don’t reply on this GitHub thread. Visit golang.org/cl/143541. |
Message from Gerrit User 13550: Patch Set 1: Code-Review-1 This was done on purpose: https://go-review.googlesource.com/c/142896 Leaving to Robert, but this seems like the wrong thing to do. Unless there is a good reason to revert that CL, which hasn't been brought up. Please don’t reply on this GitHub thread. Visit golang.org/cl/143541. |
Message from Gerrit User 24096: Patch Set 1:
We should probably then remove the isAlias function altogether. In a different CL ofcourse. Please don’t reply on this GitHub thread. Visit golang.org/cl/143541. |
Message from Gerrit User 5210: Patch Set 1: Code-Review-2
We're only supporting 3 releases (the current one in the works, 1.11, and 1.10). We're not going to introduce this. Also, isAlias is gone, so I don't know that this CL compiles. Please don’t reply on this GitHub thread. Visit golang.org/cl/143541. |
This PR is being closed because golang.org/cl/143541 has been abandoned. |
No description provided.