Fix CreateWorkflowModeContinueAsNew for SQL (#5413)

cadence-workflow · Oct 5, 2023 · 765099e · 765099e
1 parent 4a26eea
commit 765099e
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/common/persistence/sql/sqlExecutionStore.go b/common/persistence/sql/sqlExecutionStore.go
@@ -185,9 +185,13 @@ func (m *sqlExecutionStore) createWorkflowExecutionTx(
 			}
 
 		case p.CreateWorkflowModeContinueAsNew:
-			// continueAsNew mode expects a current run exists
-			if err := assertRunIDMismatch(serialization.MustParseUUID(executionInfo.RunID), row.RunID); err != nil {
-				return nil, err
+			runIDStr := row.RunID.String()
+			if runIDStr != request.PreviousRunID {
+				return nil, &p.CurrentWorkflowConditionFailedError{
+					Msg: fmt.Sprintf("Workflow execution creation condition failed. WorkflowId: %v, "+
+						"RunID: %v, PreviousRunID: %v",
+						workflowID, runIDStr, request.PreviousRunID),
+				}
 			}
 
 		default: