Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimerQueueProcessor gets stuck if timers are created very fast #461

Closed
samarabbas opened this issue Dec 12, 2017 · 0 comments · Fixed by #460
Closed

TimerQueueProcessor gets stuck if timers are created very fast #461

samarabbas opened this issue Dec 12, 2017 · 0 comments · Fixed by #460
Assignees
@samarabbas

Comments

@samarabbas
Copy link
Contributor

We repeatedly see TimerProcessor getting stuck on developer setup when there is a workflow creating timers as fast as possible.
@samarabbas samarabbas self-assigned this Dec 12, 2017
@samarabbas samarabbas mentioned this issue Dec 12, 2017
Merged
samarabbas added a commit that referenced this issue Dec 12, 2017
@samarabbas
TimerQueueProcessor stuck fix on large backlog on available timers (#460
963d13c 
)

TimerQueueProcessor issues a query to DB for visibilityTime '>=' from
the readlevel.  This could result in reading same timer multiple times
and trips the processor in thinking it fired all available timers as the
number of tasks returned back to the caller would be less than batch
size.
Updated the logic to return an explicit flag back to the caller so it
can immediately callback again when there are more timers to fire.

fixes #461.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samarabbas samarabbas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TimerQueueProcessor stuck fix on large backlog on available timers samarabbas/cadence
1 participant
@samarabbas