TimerQueueProcessor stuck fix on large backlog on available timers #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimerQueueProcessor issues a query to DB for visibilityTime '>=' from the readlevel. This could result in reading same timer multiple times and trips the processor in thinking it fired all available timers as the number of tasks returned back to the caller would be less than batch size. Updated the logic to return an explicit flag back to the caller so it can immediately callback again when there are more timers to fire.
yiminc-zz
approved these changes
Dec 12, 2017
|
Changes Unknown when pulling eabcec6 on samarabbas:workflow-timeout-stuck-issue into ** on uber:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimerQueueProcessor issues a query to DB for visibilityTime '>=' from
the readlevel. This could result in reading same timer multiple times
and trips the processor in thinking it fired all available timers as the
number of tasks returned back to the caller would be less than batch
size.
Updated the logic to return an explicit flag back to the caller so it
can immediately callback again when there are more timers to fire.
fixes #461