Implement the functionality to just wait for the last event when dumping history events #470
Conversation
| 20: optional string runId | ||
| 30: optional shared.TaskList tasklist | ||
| 40: optional bool isWorkflowRunning | ||
| // the event ID in the history event table which represent last batch of events | ||
| 50: optional i64 (js.type = "Long") lastFirstEventId |
There was a problem hiding this comment.
Probably a good time to rename this API.
There was a problem hiding this comment.
already done in #464
|
|
||
| // It is possible that we still have the events in the table even though the mutable state is gone | ||
| // Get the nextEventID from visibility store if we still have it. | ||
| visibilityResp, err := wh.visibitiltyMgr.GetClosedWorkflowExecution(&persistence.GetClosedWorkflowExecutionRequest{ |
There was a problem hiding this comment.
Cleanup the code path where we read/write NextEventID to closed workflow execution visibility store after completion. Do make sure it is not getting used anywhere else.
There was a problem hiding this comment.
searching using vs code
the call GetClosedWorkflowExecution only appears in:
VisibilityManager.go
cassandraVisibilityPersistence_test.go
cassandraVisibilityPersistence.go
visibilityInterfaces.go
so i think we are good
| return nil, wh.error(err, scope) | ||
| } | ||
| // since getHistory func will not return empty history, so the below is safe | ||
| history.Events = history.Events[len(history.Events)-1 : len(history.Events)] |
There was a problem hiding this comment.
Can you validate there is atleast one event returned by GetHistory?
Emit an error log incase no event is returned back.
There was a problem hiding this comment.
if no events return (or empty), persistence will return err
service/history/historyEngine.go
Outdated
| @@ -285,6 +285,7 @@ func (e *historyEngineImpl) StartWorkflowExecution(startRequest *h.StartWorkflow | |||
| if err1 != nil { | |||
| return nil, err1 | |||
| } | |||
| msBuilder.executionInfo.LastFirstEventID = *startedEvent.EventId | |||
There was a problem hiding this comment.
Can you use the generated Getter
| history.Events = events | ||
| if !token.IsWorkflowRunning { | ||
| history.Events = []*gen.HistoryEvent{} | ||
| if isCloseEventOnly { |
There was a problem hiding this comment.
Probably it makes sense to push the filter all the way down to history service.
There was a problem hiding this comment.
done using the int64 max as expected next event ID
| @@ -127,6 +127,7 @@ type ( | |||
| ExecutionContext []byte | |||
| State int | |||
| CloseStatus int | |||
| LastFirstEventID int64 | |||
There was a problem hiding this comment.
You need persistence changes to read/write this new field.
wxing1292
force-pushed
the
waiting-until-end
branch
2 times, most recently
from
ec6264b to
b4b1fc0
Compare
wxing1292
force-pushed
the
waiting-until-end
branch
from
b4b1fc0 to
d80a4d0
Compare
common/persistence/dataInterfaces.go
Outdated
| @@ -360,6 +360,7 @@ type ( | |||
| WorkflowTimeout int32 | |||
| DecisionTimeoutValue int32 | |||
| ExecutionContext []byte | |||
| LastFirstEventID int64 | |||
There was a problem hiding this comment.
Can we just define this as a constant? This will always have a fixed value.
wxing1292
force-pushed
the
waiting-until-end
branch
from
cba2a41 to
8656c4f
Compare
…463) * implement custpomized deduplication of start workflow execution API
…vent of when dumping history events
add missing persistant layer change
wxing1292
force-pushed
the
waiting-until-end
branch
from
8656c4f to
f73c6f2
Compare
…vent of when dumping history events