Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CreateWorkflowModeContinueAsNew for SQL #5413

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix CreateWorkflowModeContinueAsNew for SQL #5413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions common/persistence/sql/sqlExecutionStore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,13 @@ func (m *sqlExecutionStore) createWorkflowExecutionTx(
}

case p.CreateWorkflowModeContinueAsNew:
// continueAsNew mode expects a current run exists
if err := assertRunIDMismatch(serialization.MustParseUUID(executionInfo.RunID), row.RunID); err != nil {
return nil, err
runIDStr := row.RunID.String()
if runIDStr != request.PreviousRunID {
return nil, &p.CurrentWorkflowConditionFailedError{
Msg: fmt.Sprintf("Workflow execution creation condition failed. WorkflowId: %v, "+
"RunID: %v, PreviousRunID: %v",
workflowID, runIDStr, request.PreviousRunID),
}
}

default:
Expand Down