-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Buildkite CI from AWS to GKE agent queues #5912
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for doing this
7a5a20d
to
e1ffb10
Compare
617d035
to
d43d602
Compare
f84bb0a
to
d2db515
Compare
d2db515
to
e8cc37c
Compare
.buildkite/pipeline-pull-request.yml
Outdated
artifact_paths: | ||
- ".build/coverage/*.out" | ||
- ".build/coverage/metadata.txt" | ||
retry: | ||
automatic: | ||
limit: 1 | ||
agents: | ||
queue: workers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this job is failing on K8s for pull-request pipeline it will also probably fail in master pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did set pipeline-master's unit test step back to AWS, but I realized I added an extra "make just build" command to it that wasn't there previously. Will update.
c895ff3
to
14ae582
Compare
Migrate pipeline-pull-request queues to GKE Bump the test timeout for TestScanAllTrees since it keeps timing out Migrate pipeline-master Buildkite queues to GKE Add comment on how buildkite-agent is installed, add comment on yq explode
14ae582
to
e90efb0
Compare
What changed?
Why?
How did you test it?
Potential risks
Release notes
n/a
Documentation Changes
n/a