-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate unit tests from AWS to GKE #6082
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018fdf34-e6ba-4f96-b216-41f8c3285b9eDetails
💛 - Coveralls |
artifact_paths: | ||
- ".build/coverage/*.out" | ||
- ".build/coverage/metadata.txt" | ||
retry: | ||
automatic: | ||
limit: 1 | ||
plugins: | ||
- kubernetes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting this change to cause unit test
to time out because it was consistently failing during initial migration. I guess some recent changes improved the matching folder's test duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some improvements on the matching tests last Friday.
What changed?
Migrate unit tests from AWS to GKE
Why?
to complete #5912
How did you test it?
existing tests
Potential risks
Tests being flaky
can be reverted
Release notes
Documentation Changes