Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate unit tests from AWS to GKE #6082

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Jun 3, 2024

What changed?
Migrate unit tests from AWS to GKE

Why?
to complete #5912

How did you test it?
existing tests

Potential risks
Tests being flaky
can be reverted

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (f0f7efd) to head (871dd24).

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f7efd...871dd24. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fdf34-e6ba-4f96-b216-41f8c3285b9e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 67 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.01%) to 69.675%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/task/transfer_active_task_executor.go 2 72.92%
service/matching/tasklist/matcher.go 2 89.35%
common/persistence/historyManager.go 2 66.67%
service/history/task/transfer_standby_task_executor.go 3 87.14%
service/history/task/task.go 3 84.81%
tools/cli/admin_db_decode_thrift.go 4 67.95%
service/history/execution/cache.go 6 74.61%
service/history/task/fetcher.go 6 85.05%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018fdeeb-1615-4507-ae03-236a4f5abcab: -0.01%
Covered Lines: 103074
Relevant Lines: 147936

💛 - Coveralls

artifact_paths:
- ".build/coverage/*.out"
- ".build/coverage/metadata.txt"
retry:
automatic:
limit: 1
plugins:
- kubernetes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this change to cause unit test to time out because it was consistently failing during initial migration. I guess some recent changes improved the matching folder's test duration

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some improvements on the matching tests last Friday.

@Shaddoll Shaddoll merged commit 1463dc5 into cadence-workflow:master Jun 3, 2024
20 checks passed
@Shaddoll Shaddoll deleted the ci branch June 3, 2024 20:50
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants