-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split historyEngine.go into small files #5972
Split historyEngine.go into small files #5972
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
service/history/engine/engineimpl/rerespond_decision_task_completed.go
Outdated
Show resolved
Hide resolved
d115906
to
f57c17b
Compare
What changed?
historyEngine.go is a giant file with ~4k lines which makes it hard to maintain/review and add tests for.
Splitting to small files (mostly one file per public method) to make it more testable.
There are 3 separate test suites with some overlap of what they are testing
engineSuite
engine2Suite
engine3Suite
In follow up PRs we are going to add test files for each file and split (get rid of) those suites as well.
Why?
Make it more readable and testable
How did you test it?
unit tests