Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert codecov patch threshold to 85% #5982

Conversation

taylanisikdemir
Copy link
Member

What changed?
I had to bypass 85% patch coverage threshold to split the history engine into multiple files in #5972.
It's merged so bringing the threshold back.

@taylanisikdemir taylanisikdemir enabled auto-merge (squash) May 7, 2024 20:03
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (abfa99b) to head (8f7dde2).
Report is 1 commits behind head on master.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfa99b...8f7dde2. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f54af-8ded-45a2-b571-717c97db9d79

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 68.225%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
service/history/task/transfer_active_task_executor.go 2 73.16%
service/matching/taskListManager.go 2 80.65%
common/task/fifo_task_scheduler.go 3 84.54%
service/worker/scanner/executor/runq.go 3 85.48%
common/persistence/statsComputer.go 3 96.79%
service/history/handler/handler.go 4 60.59%
service/history/task/transfer_standby_task_executor.go 10 86.83%
Totals Coverage Status
Change from base Build 018f54af-1427-4fbc-bc5d-7b9472685578: 0.04%
Covered Lines: 100217
Relevant Lines: 146892

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit 306d6a8 into cadence-workflow:master May 7, 2024
20 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/revert_codecov branch May 7, 2024 20:58
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 7, 2024
abhishekj720 pushed a commit to abhishekj720/cadence that referenced this pull request May 7, 2024
agautam478 pushed a commit to agautam478/cadence that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants