Added a defensive check in the getTaskListManager function #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
force-pushed
the
matchingShardClosure
branch
from
defa363
to
3323efd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This makes sure we do not steel tasklists we do not own according to the hashring.
jakobht
force-pushed
the
matchingShardClosure
branch
from
3323efd
to
5fb4a50
Compare
jakobht
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
agautam478,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
davidporter-id-au
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a check whether or not we should own a shard before we steal it.
Why?
This makes sure we do not steal tasklists we do not own according to the
hashring.
How did you test it?
Unit tests, local runs, and deployment in dev environments.
I didn't see any ill effects from the change.
Potential risks
This code path is quite busy, so introducing a check might have performance impacts.
There is a risk that correct requests are rejected because the matching host has a wrong view of the hash ring. I expect this to be transient, and everything should be retried.
We introduce a new error, I have checked the callers and they should all handle unknown errors.
Release notes
Documentation Changes