Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix membership resolver used in integration tests #6210

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Aug 6, 2024

What changed?

  • Fix membership resolver used in integration tests

Why?
The matching simulation test is failing on some API calls after this #6199 got merged.
The AddDecisionTask and PollForDecisionTask API fails due to TaskListNotOwnedByHostError

How did you test it?
Existing tests and matching simulation test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (a711217) to head (a0ed810).
Report is 1 commits behind head on master.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a711217...a0ed810. Read the comment docs.

Copy link
Member

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a heck of a lot of sense and looks correct and reasonable to me, but: what was failing before? I can guess how this fixes it, but this all probably belongs in the commit message / PR description.

@Shaddoll
Copy link
Member Author

Shaddoll commented Aug 7, 2024

This makes a heck of a lot of sense and looks correct and reasonable to me, but: what was failing before? I can guess how this fixes it, but this all probably belongs in the commit message / PR description.

The matching simulation test is failing on some API calls after this PR got merged.
The AddDecisionTask and PollForDecisionTask API fails due to TaskListNotOwnedByHostError

@Shaddoll Shaddoll merged commit f2d0afb into cadence-workflow:master Aug 7, 2024
20 checks passed
@Shaddoll Shaddoll deleted the fix-test branch August 7, 2024 16:16
sankari165 pushed a commit to sankari165/cadence that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants