Cake.MinVer v1.0.0 release (will target Cake v1.0.0) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoproiete
commented
Nov 27, 2020
|
|
||
| var properties = typeof(MinVerSettings) | ||
| .GetProperties(BindingFlags.Public | BindingFlags.Instance | BindingFlags.FlattenHierarchy) | ||
| .Select(p => p.Name) | ||
| .ToList(); | ||
|
|
||
| // Sanity check & alarm to detect changes in properties that need to be considered in the cloning | ||
| properties.Should().HaveCount(17); | ||
| properties.Should().HaveCount(18); |
There was a problem hiding this comment.
We should replace this sanity check with a proper API snapshot approval test.
Some possibilities:
augustoproiete
force-pushed
the
release/1.0
branch
2 times, most recently
from
05c55fa to
c0af941
Compare
augustoproiete
force-pushed
the
release/1.0
branch
from
c0af941 to
23c1e98
Compare
Update repository URLs to the new location in the Cake Contrib org
Bring update license header in source files to reflect the license change in `7617fd3`
augustoproiete
force-pushed
the
master
branch
from
7add3d5 to
9ae846e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Cake.MinVer to target Cake v1.0.0