Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When building .Net Core projects prefer .Net Global Tool when available #523

Closed
7 tasks done
gep13 opened this issue Jul 5, 2020 · 0 comments · Fixed by #596
Closed
7 tasks done

When building .Net Core projects prefer .Net Global Tool when available #523

gep13 opened this issue Jul 5, 2020 · 0 comments · Fixed by #596
Assignees
@gep13
Labels
Breaking change
Milestone
2.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jul 5, 2020 •
edited by AdmiringWorm
Loading

At the minute, even though building a .Net Core project, some of the tools that are used are the full .Net Framework version. When building a .net core project we can assume that usage of .Net Global Tools are available, so we should prefer these when available.

  • GitVersion
  • GitReleaseManager
  • Codecov
  • Coveralls
  • Wyam
  • KuduSync
  • ReportGenerator
@gep13 gep13 added this to the 2.0.0 milestone Jul 5, 2020
@gep13 gep13 self-assigned this Jul 5, 2020
gep13 added a commit that referenced this issue Jul 5, 2020
@gep13
(GH-523) Prefer to use .Net Global Tool
6144074 
Initially, just for ReportGenerator, which is currently causing a
problem when running on a Mac.
gep13 added a commit that referenced this issue Jul 5, 2020
@gep13
(GH-523) Fix syntx errors
ed1718b
gep13 added a commit that referenced this issue Jul 5, 2020
@gep13
(GH-523) Use .Net Global Tools where possible
f9c5203 
These will be used when running .net core.
gep13 added a commit that referenced this issue Jul 7, 2020
@gep13
(GH-523) Include coveralls global tool
c590e49 
Switch to coveralls.net, rather than coveralls.io, as this includes a
.net Global Tool version.
gep13 added a commit that referenced this issue Jul 7, 2020
@gep13
(GH-523) Add missing property for Global Tool
cf3ae5b
@gep13 gep13 mentioned this issue Jul 8, 2020
Open
gep13 added a commit that referenced this issue Jul 8, 2020
@gep13
(GH-523) Prefer Wyam Global Tool
084b30f 
Rather than running the full .net framework version of the tool.
gep13 added a commit that referenced this issue Jul 11, 2020
@gep13
(GH-523) Pin to specific version of coveralls
99ef0a9 
The coveralls.net NuGet package is being used for both the full .net
framework version and the .Net Global tool version.  Pin to 0.7.0 for
the latest .Net framework version (which will mean it will run on Unix
systems) and also update to latest Cake.Coveralls addin which includes
a fix for a case sensitive issue.
AdmiringWorm pushed a commit to gep13/Cake.Recipe that referenced this issue Jul 11, 2020
@gep13 @AdmiringWorm
(cake-contribGH-523) Pin to specific version of coveralls
c9f484f 
The coveralls.net NuGet package is being used for both the full .net
framework version and the .Net Global tool version.  Pin to 0.7.0 for
the latest .Net framework version (which will mean it will run on Unix
systems) and also update to latest Cake.Coveralls addin which includes
a fix for a case sensitive issue.
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 11, 2020
@AdmiringWorm
(cake-contribGH-523) Update codecov to latest bug fix release
a4fb737 
The current version of codecov-exe is broken when running
on windows when running builds for normal msbuild projects.
This commit updates codecov-exe to the latest bug fix
that fixes this issue.
gep13 pushed a commit to AdmiringWorm/Cake.Recipe that referenced this issue Jul 11, 2020
@AdmiringWorm @gep13
(cake-contribGH-523) Update codecov to latest bug fix release
125903e 
The current version of codecov-exe is broken when running
on windows when running builds for normal msbuild projects.
This commit updates codecov-exe to the latest bug fix
that fixes this issue.
gep13 added a commit that referenced this issue Jul 11, 2020
@gep13
Merge pull request #562 from AdmiringWorm/update-codecov
fa75f69 
(GH-523) Update codecov to latest bug fix release
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 30, 2020
@gep13
(cake-contribGH-523) Use .Net Global tool version of KuduSync
b263005 
This is the last of the tools that can be moved to .net core.
@gep13 gep13 mentioned this issue Jul 30, 2020
Merged
AdmiringWorm added a commit that referenced this issue Jul 31, 2020
@AdmiringWorm
Merge pull request #596 from gep13/feature/GH-523
e5e3d73 
(GH-523) Use .Net Global tool version of KuduSync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Breaking change
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-523) Use .Net Global tool version of KuduSync gep13/Cake.Recipe
1 participant
@gep13