Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-523) Use .Net Global tool version of KuduSync #596

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jul 30, 2020

This is the last of the tools that can be moved to .net core.

Fixes #523

This is the last of the tools that can be moved to .net core.
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I won't be merging this yet, as you have also requested a review from @devlead

@gep13
Copy link
Member Author

gep13 commented Jul 31, 2020

@AdmiringWorm I spoke with @devlead on Slack last night, and he was fine with this getting merged. I will move him as a reviewer.

@gep13 gep13 removed the request for review from devlead July 31, 2020 13:17
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit e5e3d73 into cake-contrib:develop Jul 31, 2020
@AdmiringWorm
Copy link
Member

@gep13 your changes have been merged, thanks for your contribution 👍

and thank you @devlead for making it possible

@gep13 gep13 deleted the feature/GH-523 branch July 31, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When building .Net Core projects prefer .Net Global Tool when available
3 participants