[BREAKING] feat: invert the --reverse-port CLI option (#825)

* feat: invert the reverse port flag * chore: add changeset * fix: rely only on revertPort flag
callstack · Dec 16, 2024 · 18f2eef · 18f2eef
1 parent 8cf7cc3
commit 18f2eef
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/.changeset/dull-ants-change.md b/.changeset/dull-ants-change.md
@@ -0,0 +1,5 @@
+---
+"@callstack/repack": major
+---
+
+Removed `--reverse-port` CLI option and replaced it with `--no-reverse-port` CLI option.
diff --git a/packages/repack/src/commands/options.ts b/packages/repack/src/commands/options.ts
@@ -51,8 +51,9 @@ export const startCommandOptions = [
       'Run the dev server for the specified platform only. By default, the dev server will bundle for all platforms.',
   },
   {
-    name: '--reverse-port',
-    description: 'ADB reverse port on starting devServers only for Android',
+    name: '--no-reverse-port',
+    description:
+      'Disables running ADB reverse automatically when bundling for Android',
   },
   {
     name: '--verbose',

diff --git a/packages/repack/src/commands/rspack/start.ts b/packages/repack/src/commands/rspack/start.ts
@@ -126,11 +126,7 @@ export async function start(
         );
       }
 
-      if (
-        reversePort ||
-        args.platform === undefined ||
-        args.platform === 'android'
-      ) {
+      if (reversePort) {
         void runAdbReverse({ port: serverPort, logger: ctx.log });
       }
 

diff --git a/packages/repack/src/commands/webpack/start.ts b/packages/repack/src/commands/webpack/start.ts
@@ -124,11 +124,7 @@ export async function start(_: string[], config: Config, args: StartArguments) {
         );
       }
 
-      if (
-        reversePort ||
-        args.platform === undefined ||
-        args.platform === 'android'
-      ) {
+      if (reversePort) {
         void runAdbReverse({ port: serverPort, logger: ctx.log });
       }