Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] feat: invert the --reverse-port CLI option #825

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 12, 2024

Summary

Since adb reverse will be now run by default, the CLI option of --reverse-port was reworked into --no-reverse-port to turn off the default behaviour

Test plan

n/a

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 3092d0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major
@callstack/repack-init Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 1:12pm

@jbroma jbroma changed the title feat: invert the --reverse-port flag into --no-reverse-port [BREAKING CHANGE] feat: invert the --reverse-port CLI option Dec 12, 2024
@jbroma jbroma changed the title [BREAKING CHANGE] feat: invert the --reverse-port CLI option [BREAKING] feat: invert the --reverse-port CLI option Dec 12, 2024
@jbroma jbroma merged commit 18f2eef into main Dec 16, 2024
5 checks passed
@jbroma jbroma deleted the feat/no-reverse-port branch December 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants