feat(TextInput): add typescript types #13142

bianca-sparxs · 2023-02-13T22:47:20Z

Closes #12561

Part of #12513 to convert the propTypes of the TextInput component into typescript type interface.

Changelog

Changed

TextInput.js converted to .tsx
Typescript interface added to reflect proptypes and definitelyTyped types of this component
useNormalizedInputProps jsdocs updated to reflect more accurate input types, since Typescript will infer a Typescript definition from those docs
add self to contributors

Testing / Reviewing

Take a storybook component that uses TextInput, paste at the bottom of the .tsx file and make changes to the component (i.e add props, add incorrect types) and verify types are correctly enforced

github-actions · 2023-02-13T22:47:40Z

DCO Assistant Lite bot All contributors have signed the DCO.

netlify · 2023-02-13T22:52:32Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`da366fe`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/6400f2e0357038000851b32b
😎 Deploy Preview	https://deploy-preview-13142--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…513-text-input-types

bianca-sparxs · 2023-02-13T22:54:59Z

I have read the DCO document and I hereby sign the DCO.

bianca-sparxs · 2023-02-13T22:55:17Z

recheck

packages/react/src/components/TextInput/TextInput.tsx

…513-text-input-types

bianca-sparxs · 2023-02-21T18:53:35Z

Hey @francinelucca thanks, merge conflicts were resolved! :)

netlify · 2023-02-21T18:57:50Z

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`da366fe`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/6400f2e092847c0008eecb0f
😎 Deploy Preview	https://deploy-preview-13142--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

francinelucca

Thanks for putting this together @bianca-sparxs!

Mostly LGTM, just some minor change requests and looks like there's some merge conflicts 🙏🏻

packages/react/src/components/TextInput/TextInput.tsx

packages/react/src/internal/useNormalizedInputProps.js

packages/react/src/components/TextInput/TextInput.tsx

…513-text-input-types

carbon-bot · 2023-03-03T15:17:17Z

Hey there! v11.24.0 was just released that references this issue/PR.

* refactor(Dropdown): ariaLabel to aria-label * fix(menu): fix arrow key navigation when onClose is called but not closed (#13195) * fix(menu): only clear registered items when root is closing * fix(menu): auto-cleanup registered items --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(theme): add $icon-interactive token (#13219) * feat(theme): add $icon-interactive token * Update packages/themes/src/tokens/v11TokenGroup.js Co-authored-by: Alison Joseph <[email protected]> * Update packages/themes/src/tokens/__tests__/metadata-test.js Co-authored-by: Alison Joseph <[email protected]> * Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap * Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap * chore(snapshot): update snapshots --------- Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: Francine Lucca <[email protected]> * feat(TextInput): add typescript types (#13142) * feat(TextInput): add typescript types * fix(Text Input): submcompnent workaround + add helperID prop * chore(format): format `Popover`, `Listbox` files (#13284) * chore(format): format Popover file * chore(format): format ListBox files * chore(format): update format command * chore(release): v11.24.0 (#13282) Co-authored-by: tay1orjones <[email protected]> * fix(toggle): make props.labelText optional (#13196) * fix(toggle): make props.labelText optional * docs(toggle): add 'with accessible labels' story * test(toggle): update public api snapshot --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(ListBox): a11y - move filter tag as sibling of menu trigger, esc key improvements (#13173) * fix(MultiSelect): a11y - move filter tag as sibling of menu trigger * fix(Multiselect): remove tag from tab order * fix(FilterableMultiselect): remove clear, tag from tab order * fix(ComboBox): retain input value when menu is open and esc is pressed * fix(FilterableMultiSelect): a few more UX tweaks * style(MultiSelect): update styles to fix invalid issues when focused * style(FluidMultiselect): adjust focus styles when invalid * chore(log): remove console log --------- Co-authored-by: Andrea N. Cardona <[email protected]> * docs(style): add section on authoring inline styles (#13289) * docs(style): add section on authoring inline styles * docs(style): rephrase inline style docs * docs(style): typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(ComboBox): ariaLabel to aria-label (#13273) * refactor(ComboBox): ariaLabel to aria-label * fix: formatting --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <[email protected]> * fix(tabs): remove max-width (#13247) * fix(tabs): remove max-width * docs(tabs): add max width guidance * docs(tabs): format --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(ListBox): Standardize `ListBox` menu open behavior (#13268) * style(MultiSelect): update styles to fix invalid issues when focused * style(FluidMultiselect): adjust focus styles when invalid * chore(log): remove console log * fix(ListBox): align open behaviors across ListBox components --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Add Typescript annotations to Select, SelectItem and SelectItemGroup (#13235) * refactor(typescript): type annotations on Select* Add Typescript annotations to Select, SelectItem and SelectItemGroup. * fix(lint): removed unused imports Left SelectItem and SelectItemGroup in the imports after using them for testing. Removed. * fix(Select-test): update label to labelText Previously removed label as it was not a property of Select. On recommendation of maintainers reintroduced using labelText. * Apply suggestions from code review Co-authored-by: Andrea N. Cardona <[email protected]> * Follow up to change suggestions --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(FilterableMultiSelect): ariaLabel to aria-label (#13276) Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> * fix(SkeletonText): prevent negative px width values (#13270) Co-authored-by: Alessandra Davila <[email protected]> * feat(Popover): add `isTabTip` prop to `Popover` (#13283) * feat(tabTipPopover): add tabTip to Popover * feat(tabTipPopover): add tab-tip styles, story * test(Popover): add e2e tests * style(Popover): adjust storybook styles * fix(Popover): add new prop to proptypes * chore(snapshot): update snapshots * docs(Popover): add close on esc to story * docs(Popover): fix typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(deps): bump minimist in /packages/react/examples/react-router (#13254) Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(StructuredList): ariaLabel to aria-label (#13261) * refactor(StructuredListWrapper): ariaLabel to aria-label * fix(StructuredList test): use 'aria-label' --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(DataTable): add rowIds to the sortRows extra params list (#13236) Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(typescript): add various typescript typings (#13234) * feat(TableToolbar): add typescript typings * feat(TableToolbarAction): add typescript typings * feat(TableToolbarContent): change to `tsx` * feat(TableToolbarMenu): add typescript typings * feat(OverflowMenuItem): add typescript typings * fix: format --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Francine Lucca <[email protected]> * fix(RadioTile): forward ref to input node (#13130) Forward ref to input node of RadioTile, such that it behaves the same as other form inputs. Co-authored-by: Francine Lucca <[email protected]> * feat: migration examples prefix selectors (#13264) * feat(ContentSwitcher): preliminary unstable refactor * feat: added prefix and id prefix examples * fix: delete content switcher directory * feat: update demos * Update examples/id-prefix/src/App.jsx Co-authored-by: Francine Lucca <[email protected]> * Update packages/react/src/components/IdPrefix/index.js * feat: added docs * fix: update context * fix: yarn install * fix: update context 2 * chore: update yarn packages * chore: udpate yarn carbon/react --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(DataTableSkeleton): 12513 - Add TS types for props (#13245) * feat(DataTableSkeleton): 12513 - Add TS types for props * fix: yarn run format --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Francine Lucca <[email protected]> * test(datatable): refactor to use RTL (#13294) * chore: wip * chore: wip * test(datatable): refactor to use RTL * chore: typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(modal): aria-label a11y bug (#13242) Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * test(HeaderSideNavItems): add tests (#13303) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs(Storybook): update storybook config so actions display properly (#13302) * docs(Storybook): update storybook config so actions display properly * fix(DatePicker): change action names --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(tabs): deprecate light prop (#13262) Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(menu): focus first item when opened (#13277) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(CodeSnippet): a11y tabstop + attributes (#13310) * fix(CodeSnippet): a11y tabstop + attributes * fix(CSS): add Carbon CSS to focus outline * refactor(CodeSnippet): relocate parens * refactor(OverflowMenu): ariaLabel to aria-label (NEW) (#13280) * fix(CodeSnippet): a11y tabstop + attributes * fix(CSS): add Carbon CSS to focus outline * refactor(OverflowMenu): ariaLabel to aria-label NEW * Delete CodeSnippet.js error from a rebase/merge * Delete _code-snippet.scss error from rebase/merge * revert(missingFiles): they'll be ignored on merge --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(test): remove enzyme (#13316) * test(accordion): refactor from enzyme to RTL * chore(test): remove enzyme --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(CodeSnippet): ariaLabel to aria-label (#13274) Co-authored-by: Taylor Jones <[email protected]> * feat(TextArea): add warning state (#13293) * feat(TextArea): add warning state * chore: update snapshots * fix: textarea error bottom border and default value in story * chore: hide resize fluid textarea invalid and warn --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor: convert TextAreaSkeleton to TypeScript (#13275) * refactor: convert TextAreaSkeleton to TypeScript * chore: remove unneeded omit * chore: remove unneeded omit --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(batchToolTips): make tooltips on batch visible (#13328) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(Notification): ariaLabel to aria-label (#13281) * refactor(Notification): ariaLabel to aria-label * fix(Notification): rm stories default dupes * fix(InlineNotification): rm deprecated prop --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(format): tsx formatting --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jan Hassel <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Bianca Sparxs <[email protected]> Co-authored-by: carbon-automation[bot] <103539138+carbon-automation[bot]@users.noreply.github.com> Co-authored-by: tay1orjones <[email protected]> Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: jpsorensen <[email protected]> Co-authored-by: andrew <[email protected]> Co-authored-by: Alessandra Davila <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Knabe <[email protected]> Co-authored-by: GalvinGao <[email protected]> Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: remolueoend <[email protected]> Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: Sierra Wetmore <[email protected]> Co-authored-by: Austin <[email protected]>

feat(TextInput): add typescript types

f5e3696

bianca-sparxs requested a review from a team as a code owner February 13, 2023 22:47

bianca-sparxs requested review from alisonjoseph and aledavila February 13, 2023 22:47

Merge branch 'main' of github.com:carbon-design-system/carbon into 12…

974128f

…513-text-input-types

bianca-sparxs commented Feb 13, 2023

View reviewed changes

packages/react/src/components/TextInput/TextInput.tsx Show resolved Hide resolved

francinelucca added the status: merge conflict 🚫 label Feb 21, 2023

Merge branch 'main' of github.com:carbon-design-system/carbon into 12…

759aeb6

…513-text-input-types

francinelucca removed the status: merge conflict 🚫 label Feb 21, 2023

francinelucca added the status: ready for review 👀 label Feb 21, 2023

francinelucca requested changes Feb 27, 2023

View reviewed changes

packages/react/src/components/TextInput/TextInput.tsx Outdated Show resolved Hide resolved

packages/react/src/internal/useNormalizedInputProps.js Outdated Show resolved Hide resolved

packages/react/src/components/TextInput/TextInput.tsx Outdated Show resolved Hide resolved

bianca-sparxs added 2 commits February 28, 2023 12:21

Merge branch 'main' of github.com:carbon-design-system/carbon into 12…

1b5460a

…513-text-input-types

fix(Text Input): submcompnent workaround + add helperID prop

b08e3bd

bianca-sparxs requested review from francinelucca and removed request for alisonjoseph and aledavila February 28, 2023 18:46

francinelucca requested review from alisonjoseph and aledavila February 28, 2023 19:59

francinelucca approved these changes Feb 28, 2023

View reviewed changes

francinelucca added status: one more review 👀 and removed status: ready for review 👀 labels Feb 28, 2023

alisonjoseph approved these changes Mar 1, 2023

View reviewed changes

alisonjoseph added status: ready to merge 🎉 and removed status: one more review 👀 labels Mar 1, 2023

Merge branch 'main' into 12513-text-input-types

da366fe

kodiakhq bot merged commit e1d4884 into carbon-design-system:main Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(TextInput): add typescript types #13142

feat(TextInput): add typescript types #13142

bianca-sparxs commented Feb 13, 2023

github-actions bot commented Feb 13, 2023 •

edited

Loading

netlify bot commented Feb 13, 2023 •

edited

Loading

bianca-sparxs commented Feb 13, 2023

bianca-sparxs commented Feb 13, 2023

bianca-sparxs commented Feb 21, 2023

netlify bot commented Feb 21, 2023 •

edited

Loading

francinelucca left a comment

carbon-bot commented Mar 3, 2023

feat(TextInput): add typescript types #13142

feat(TextInput): add typescript types #13142

Conversation

bianca-sparxs commented Feb 13, 2023

Changelog

Testing / Reviewing

github-actions bot commented Feb 13, 2023 • edited Loading

netlify bot commented Feb 13, 2023 • edited Loading

✅ Deploy Preview for carbon-elements ready!

bianca-sparxs commented Feb 13, 2023

bianca-sparxs commented Feb 13, 2023

bianca-sparxs commented Feb 21, 2023

netlify bot commented Feb 21, 2023 • edited Loading

✅ Deploy Preview for carbon-components-react ready!

francinelucca left a comment

Choose a reason for hiding this comment

carbon-bot commented Mar 3, 2023

github-actions bot commented Feb 13, 2023 •

edited

Loading

netlify bot commented Feb 13, 2023 •

edited

Loading

netlify bot commented Feb 21, 2023 •

edited

Loading