feat: migration examples prefix selectors #13264

andreancardona · 2023-03-01T04:00:33Z

add prefix example
add id-prefix example

Testing / Reviewing

checkout PR locally and cd into examples/class-prefix and examples/id-prefix run yarn dev

packages/react/src/internal/useIdPrefix.js

francinelucca

mostly LGTM, some questions.

Should we add a README.md to the examples with info on the app and basic install/run instructions ? See https://github.com/carbon-design-system/carbon/tree/main/examples/incremental-migration#readme

packages/react/src/components/IdPrefix/index.js

examples/id-prefix/src/App.jsx

Co-authored-by: Francine Lucca <[email protected]>

packages/react/src/components/IdPrefix/index.js

…m:andreancardona/carbon into 12342-migration-examples-prefix-selectors

francinelucca

LGTM! pending Taylor's reply on packages/react/src/internal/useIdPrefix.js changes.

Also looks like some of the CI checks were not successful @andreancardona

tay1orjones · 2023-03-02T20:58:23Z

Also looks like some of the CI checks were not successful @andreancardona

I think it just needs a yarn install at the root?

netlify · 2023-03-03T21:58:46Z

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`c6f0a30`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-react/deploys/64089be1bc713d0008ca22b2
😎 Deploy Preview	https://deploy-preview-13264--carbon-components-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-03-03T21:59:27Z

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	`c6f0a30`
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-elements/deploys/64089be134a5e700084d35f3
😎 Deploy Preview	https://deploy-preview-13264--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…m:andreancardona/carbon into andreancardona-12342-migration-examples-prefix-selectors-2

…s-2'

…342-migration-examples-prefix-selectors

tay1orjones

LGTM! 🎉

* refactor(Dropdown): ariaLabel to aria-label * fix(menu): fix arrow key navigation when onClose is called but not closed (#13195) * fix(menu): only clear registered items when root is closing * fix(menu): auto-cleanup registered items --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(theme): add $icon-interactive token (#13219) * feat(theme): add $icon-interactive token * Update packages/themes/src/tokens/v11TokenGroup.js Co-authored-by: Alison Joseph <[email protected]> * Update packages/themes/src/tokens/__tests__/metadata-test.js Co-authored-by: Alison Joseph <[email protected]> * Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap * Update packages/themes/src/tokens/__tests__/__snapshots__/v11-test.js.snap * chore(snapshot): update snapshots --------- Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: Francine Lucca <[email protected]> * feat(TextInput): add typescript types (#13142) * feat(TextInput): add typescript types * fix(Text Input): submcompnent workaround + add helperID prop * chore(format): format `Popover`, `Listbox` files (#13284) * chore(format): format Popover file * chore(format): format ListBox files * chore(format): update format command * chore(release): v11.24.0 (#13282) Co-authored-by: tay1orjones <[email protected]> * fix(toggle): make props.labelText optional (#13196) * fix(toggle): make props.labelText optional * docs(toggle): add 'with accessible labels' story * test(toggle): update public api snapshot --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(ListBox): a11y - move filter tag as sibling of menu trigger, esc key improvements (#13173) * fix(MultiSelect): a11y - move filter tag as sibling of menu trigger * fix(Multiselect): remove tag from tab order * fix(FilterableMultiselect): remove clear, tag from tab order * fix(ComboBox): retain input value when menu is open and esc is pressed * fix(FilterableMultiSelect): a few more UX tweaks * style(MultiSelect): update styles to fix invalid issues when focused * style(FluidMultiselect): adjust focus styles when invalid * chore(log): remove console log --------- Co-authored-by: Andrea N. Cardona <[email protected]> * docs(style): add section on authoring inline styles (#13289) * docs(style): add section on authoring inline styles * docs(style): rephrase inline style docs * docs(style): typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(ComboBox): ariaLabel to aria-label (#13273) * refactor(ComboBox): ariaLabel to aria-label * fix: formatting --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <[email protected]> * fix(tabs): remove max-width (#13247) * fix(tabs): remove max-width * docs(tabs): add max width guidance * docs(tabs): format --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(ListBox): Standardize `ListBox` menu open behavior (#13268) * style(MultiSelect): update styles to fix invalid issues when focused * style(FluidMultiselect): adjust focus styles when invalid * chore(log): remove console log * fix(ListBox): align open behaviors across ListBox components --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Add Typescript annotations to Select, SelectItem and SelectItemGroup (#13235) * refactor(typescript): type annotations on Select* Add Typescript annotations to Select, SelectItem and SelectItemGroup. * fix(lint): removed unused imports Left SelectItem and SelectItemGroup in the imports after using them for testing. Removed. * fix(Select-test): update label to labelText Previously removed label as it was not a property of Select. On recommendation of maintainers reintroduced using labelText. * Apply suggestions from code review Co-authored-by: Andrea N. Cardona <[email protected]> * Follow up to change suggestions --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(FilterableMultiSelect): ariaLabel to aria-label (#13276) Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> * fix(SkeletonText): prevent negative px width values (#13270) Co-authored-by: Alessandra Davila <[email protected]> * feat(Popover): add `isTabTip` prop to `Popover` (#13283) * feat(tabTipPopover): add tabTip to Popover * feat(tabTipPopover): add tab-tip styles, story * test(Popover): add e2e tests * style(Popover): adjust storybook styles * fix(Popover): add new prop to proptypes * chore(snapshot): update snapshots * docs(Popover): add close on esc to story * docs(Popover): fix typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(deps): bump minimist in /packages/react/examples/react-router (#13254) Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(StructuredList): ariaLabel to aria-label (#13261) * refactor(StructuredListWrapper): ariaLabel to aria-label * fix(StructuredList test): use 'aria-label' --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(DataTable): add rowIds to the sortRows extra params list (#13236) Co-authored-by: TJ Egan <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(typescript): add various typescript typings (#13234) * feat(TableToolbar): add typescript typings * feat(TableToolbarAction): add typescript typings * feat(TableToolbarContent): change to `tsx` * feat(TableToolbarMenu): add typescript typings * feat(OverflowMenuItem): add typescript typings * fix: format --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Francine Lucca <[email protected]> * fix(RadioTile): forward ref to input node (#13130) Forward ref to input node of RadioTile, such that it behaves the same as other form inputs. Co-authored-by: Francine Lucca <[email protected]> * feat: migration examples prefix selectors (#13264) * feat(ContentSwitcher): preliminary unstable refactor * feat: added prefix and id prefix examples * fix: delete content switcher directory * feat: update demos * Update examples/id-prefix/src/App.jsx Co-authored-by: Francine Lucca <[email protected]> * Update packages/react/src/components/IdPrefix/index.js * feat: added docs * fix: update context * fix: yarn install * fix: update context 2 * chore: update yarn packages * chore: udpate yarn carbon/react --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(DataTableSkeleton): 12513 - Add TS types for props (#13245) * feat(DataTableSkeleton): 12513 - Add TS types for props * fix: yarn run format --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Francine Lucca <[email protected]> * test(datatable): refactor to use RTL (#13294) * chore: wip * chore: wip * test(datatable): refactor to use RTL * chore: typo --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(modal): aria-label a11y bug (#13242) Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * test(HeaderSideNavItems): add tests (#13303) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * docs(Storybook): update storybook config so actions display properly (#13302) * docs(Storybook): update storybook config so actions display properly * fix(DatePicker): change action names --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(tabs): deprecate light prop (#13262) Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(menu): focus first item when opened (#13277) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(CodeSnippet): a11y tabstop + attributes (#13310) * fix(CodeSnippet): a11y tabstop + attributes * fix(CSS): add Carbon CSS to focus outline * refactor(CodeSnippet): relocate parens * refactor(OverflowMenu): ariaLabel to aria-label (NEW) (#13280) * fix(CodeSnippet): a11y tabstop + attributes * fix(CSS): add Carbon CSS to focus outline * refactor(OverflowMenu): ariaLabel to aria-label NEW * Delete CodeSnippet.js error from a rebase/merge * Delete _code-snippet.scss error from rebase/merge * revert(missingFiles): they'll be ignored on merge --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(test): remove enzyme (#13316) * test(accordion): refactor from enzyme to RTL * chore(test): remove enzyme --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(CodeSnippet): ariaLabel to aria-label (#13274) Co-authored-by: Taylor Jones <[email protected]> * feat(TextArea): add warning state (#13293) * feat(TextArea): add warning state * chore: update snapshots * fix: textarea error bottom border and default value in story * chore: hide resize fluid textarea invalid and warn --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor: convert TextAreaSkeleton to TypeScript (#13275) * refactor: convert TextAreaSkeleton to TypeScript * chore: remove unneeded omit * chore: remove unneeded omit --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(batchToolTips): make tooltips on batch visible (#13328) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * refactor(Notification): ariaLabel to aria-label (#13281) * refactor(Notification): ariaLabel to aria-label * fix(Notification): rm stories default dupes * fix(InlineNotification): rm deprecated prop --------- Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(format): tsx formatting --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jan Hassel <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Bianca Sparxs <[email protected]> Co-authored-by: carbon-automation[bot] <103539138+carbon-automation[bot]@users.noreply.github.com> Co-authored-by: tay1orjones <[email protected]> Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: jpsorensen <[email protected]> Co-authored-by: andrew <[email protected]> Co-authored-by: Alessandra Davila <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Knabe <[email protected]> Co-authored-by: GalvinGao <[email protected]> Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: remolueoend <[email protected]> Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: Sierra Wetmore <[email protected]> Co-authored-by: Austin <[email protected]>

andreancardona and others added 8 commits August 26, 2021 15:01

feat(ContentSwitcher): preliminary unstable refactor

e5674f4

Merge branch 'main' of github.com:carbon-design-system/carbon

7071564

Merge branch 'main' of github.com:carbon-design-system/carbon

0d12bdb

Merge branch 'main' of github.com:carbon-design-system/carbon

bc65356

Merge branch 'main' of github.com:carbon-design-system/carbon

87c325d

Merge branch 'main' of github.com:carbon-design-system/carbon

98bc81a

Merge branch 'main' of github.com:carbon-design-system/carbon

2e02582

feat: added prefix and id prefix examples

d875f9c

andreancardona requested a review from a team as a code owner March 1, 2023 04:00

andreancardona requested review from tay1orjones and francinelucca March 1, 2023 04:00

andreancardona added 3 commits February 28, 2023 21:04

fix: delete content switcher directory

9e71a5c

feat: update demos

1e202ac

Merge branch 'main' into 12342-migration-examples-prefix-selectors

5bf7f3d

andreancardona commented Mar 1, 2023

View reviewed changes

packages/react/src/internal/useIdPrefix.js Outdated Show resolved Hide resolved

francinelucca requested changes Mar 1, 2023

View reviewed changes

packages/react/src/components/IdPrefix/index.js Outdated Show resolved Hide resolved

examples/id-prefix/src/App.jsx Outdated Show resolved Hide resolved

Update examples/id-prefix/src/App.jsx

c45bd9f

Co-authored-by: Francine Lucca <[email protected]>

andreancardona commented Mar 1, 2023

View reviewed changes

packages/react/src/components/IdPrefix/index.js Outdated Show resolved Hide resolved

andreancardona added 3 commits March 1, 2023 09:57

Update packages/react/src/components/IdPrefix/index.js

36adcf6

feat: added docs

fe7c047

Merge branch '12342-migration-examples-prefix-selectors' of github.co…

7f8dbde

…m:andreancardona/carbon into 12342-migration-examples-prefix-selectors

andreancardona requested a review from francinelucca March 2, 2023 16:21

francinelucca reviewed Mar 2, 2023

View reviewed changes

andreancardona added 2 commits March 3, 2023 14:53

fix: update context

29afca0

fix: yarn install

2e1b93c

andreancardona added 2 commits March 3, 2023 15:06

fix: update context 2

ea4b06f

Merge branch 'andreancardona-12342-migration-examples-prefix-selectors'

16cde8e

andreancardona added 5 commits March 7, 2023 11:10

Merge branch '12342-migration-examples-prefix-selectors' of github.co…

722ce0c

…m:andreancardona/carbon into andreancardona-12342-migration-examples-prefix-selectors-2

Merge branch 'andreancardona-12342-migration-examples-prefix-selector…

055fce5

…s-2'

Merge branch 'main' of github.com:carbon-design-system/carbon into 12…

c7b7b6d

…342-migration-examples-prefix-selectors

chore: update yarn packages

c3c7df5

chore: udpate yarn carbon/react

06edde4

francinelucca approved these changes Mar 7, 2023

View reviewed changes

francinelucca added the status: one more review 👀 label Mar 7, 2023

tay1orjones approved these changes Mar 8, 2023

View reviewed changes

alisonjoseph added status: ready to merge 🎉 and removed status: one more review 👀 labels Mar 8, 2023

Merge branch 'main' into 12342-migration-examples-prefix-selectors

c6f0a30

kodiakhq bot merged commit 0c9b4fd into carbon-design-system:main Mar 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migration examples prefix selectors #13264

feat: migration examples prefix selectors #13264

andreancardona commented Mar 1, 2023 •

edited

Loading

francinelucca left a comment

francinelucca left a comment

tay1orjones commented Mar 2, 2023

netlify bot commented Mar 3, 2023 •

edited

Loading

netlify bot commented Mar 3, 2023 •

edited

Loading

tay1orjones left a comment

feat: migration examples prefix selectors #13264

feat: migration examples prefix selectors #13264

Conversation

andreancardona commented Mar 1, 2023 • edited Loading

francinelucca left a comment

Choose a reason for hiding this comment

francinelucca left a comment

Choose a reason for hiding this comment

tay1orjones commented Mar 2, 2023

netlify bot commented Mar 3, 2023 • edited Loading

✅ Deploy Preview for carbon-components-react ready!

netlify bot commented Mar 3, 2023 • edited Loading

✅ Deploy Preview for carbon-elements ready!

tay1orjones left a comment

Choose a reason for hiding this comment

andreancardona commented Mar 1, 2023 •

edited

Loading

netlify bot commented Mar 3, 2023 •

edited

Loading

netlify bot commented Mar 3, 2023 •

edited

Loading