refactor(padding): implements css logical props #6774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMelox
requested review from
devadula-nandan and
sangeethababu9223
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
==========================================
+ Coverage 81.17% 81.26% +0.09%
==========================================
Files 398 397 -1
Lines 12956 12949 -7
Branches 4283 4281 -2
==========================================
+ Hits 10517 10523 +6
+ Misses 2439 2426 -13
|
AlexanderMelox
force-pushed
the
refactor--css-logical-properties-paddings
branch
from
b7f8506 to
de57572
Compare
2 tasks
sangeethababu9223
previously approved these changes
Jan 30, 2025
packages/ibm-products-styles/src/components/Datagrid/styles/addons/_RowSizeDropdown.scss
Outdated
Show resolved
Hide resolved
AlexanderMelox
commented
Feb 3, 2025
packages/ibm-products-styles/src/components/Datagrid/styles/addons/_RowSizeDropdown.scss
Outdated
Show resolved
Hide resolved
…dons/_RowSizeDropdown.scss
devadula-nandan
approved these changes
Feb 3, 2025
sangeethababu9223
approved these changes
Feb 3, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 3, 2025
f9fbf85
32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3556
This PR changes the following to use CSS Logical Properties:
Similar PR in core -> carbon-design-system/carbon#14531
Changed
Things to look out for while reviewing: Since I mostly did a find and replace, some lines might be changed that shouldn't that includes the following:
--nav-height:shouldn't be changed