chore: enables css logical property rule #6879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMelox
requested review from
devadula-nandan and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6879 +/- ##
==========================================
- Coverage 81.51% 81.44% -0.07%
==========================================
Files 399 399
Lines 12975 12975
Branches 4268 4268
==========================================
- Hits 10577 10568 -9
- Misses 2398 2407 +9
|
devadula-nandan
approved these changes
Feb 12, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 12, 2025
018e69f
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6802
We merged all css logical properties PR so now we can enable the linter to give us errors from now on.
PR List
What did you change?
How did you verify it works?
I added physical properties and it gave errors, also using
yarn lint:stylesshould fix most of the errors