refactor(positions): implements css logical props #6777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6777 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 397 397
Lines 12959 12959
Branches 4261 4261
=======================================
Hits 10537 10537
Misses 2422 2422
|
2 tasks
AlexanderMelox
force-pushed
the
refactor--css-logical-properties-positions
branch
from
b2949c7 to
e1c6cd4
Compare
AlexanderMelox
requested review from
matthewgallo and
devadula-nandan
and removed request for
a team
matthewgallo
reviewed
Feb 6, 2025
packages/ibm-products-styles/src/components/Coachmark/_coachmark-overlay.scss
Outdated
Show resolved
Hide resolved
matthewgallo
previously approved these changes
Feb 6, 2025
AlexanderMelox
commented
Feb 6, 2025
packages/ibm-products-styles/src/components/Coachmark/_coachmark-overlay.scss
Outdated
Show resolved
Hide resolved
matthewgallo
approved these changes
Feb 6, 2025
devadula-nandan
approved these changes
Feb 6, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 6, 2025
44a206d
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3556
This PR changes the following to use CSS Logical Properties:
Similar PR in core -> carbon-design-system/carbon#14531
Changed
Things to look out for while reviewing: Since I mostly did a find and replace, some lines might be changed that shouldn't that includes the following:
--nav-height:shouldn't be changed