Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file attribute caching #854

Closed
3 tasks done
steve-todorov opened this issue Oct 28, 2024 · 0 comments · Fixed by #855
Closed
3 tasks done

Improve file attribute caching #854

steve-todorov opened this issue Oct 28, 2024 · 0 comments · Fixed by #855
Labels
performance Performance improvements or problems

Comments

@steve-todorov
Copy link
Collaborator

Task Description

The current implementation of the file attribute caching is very basic and is still executing some REST API instead of hitting the cache. We need to improve this.

Tasks

The following tasks will need to be carried out:

  • Use Caffeine for caching instead of re-inventing the wheel.
  • Replace and improve the file attribute cache implementation.
  • Ensure a test validates the cache is being used and works as expected.

Task Relationships

This task:

  • Is a sub-task of: #
  • Depends on: #
  • Is a follow-up of: #
  • Relates to: #

Useful Links

Help
@steve-todorov steve-todorov added the performance Performance improvements or problems label Oct 28, 2024
steve-todorov added a commit that referenced this issue Oct 29, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
7b78be0 
BREAKING CHANGE: `S3FileSystem#getCache()` method was removed
BREAKING CHANGE: `S3Path#setFileAttributes()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#getCache()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#setCache()` was removed.
steve-todorov added a commit that referenced this issue Oct 29, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
08d14c2 
BREAKING CHANGE: `S3FileSystem#getCache()` method was removed
BREAKING CHANGE: `S3Path#setFileAttributes()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#getCache()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#setCache()` was removed.
@steve-todorov steve-todorov mentioned this issue Oct 29, 2024
Merged
7 tasks
steve-todorov added a commit that referenced this issue Nov 5, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
154d72a 
BREAKING CHANGE: `S3OutputStream` constructor signatures changed
steve-todorov added a commit that referenced this issue Nov 6, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
79d7191 
BREAKING CHANGE: `S3OutputStream` constructor signatures changed
steve-todorov added a commit that referenced this issue Nov 6, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
e072cfe 
BREAKING CHANGE: `S3FileSystem#getCache()` method was removed
BREAKING CHANGE: `S3Path#setFileAttributes()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#getCache()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#setCache()` was removed.
steve-todorov added a commit that referenced this issue Nov 6, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
3b2943d 
BREAKING CHANGE: `S3OutputStream` constructor signatures changed
steve-todorov added a commit that referenced this issue Nov 6, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
ecb5f5d
steve-todorov added a commit that referenced this issue Nov 6, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
bbcf747
steve-todorov added a commit that referenced this issue Nov 7, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
3d73a1f 
Add logging.
steve-todorov added a commit that referenced this issue Nov 7, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
7cc3d79 
Add logging.
steve-todorov added a commit that referenced this issue Nov 7, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
e03a486 
Set the default cache size to 30k
steve-todorov added a commit that referenced this issue Nov 21, 2024
@steve-todorov
feat!: Improve file attribute caching (#854)
596434b 
BREAKING CHANGE: `S3FileSystem#getCache()` method was removed
BREAKING CHANGE: `S3Path#setFileAttributes()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#getCache()` was removed.
BREAKING CHANGE: `S3FileSystemProvider#setCache()` was removed.
BREAKING CHANGE: `S3OutputStream` constructor signatures changed
steve-todorov added a commit that referenced this issue Nov 21, 2024
@steve-todorov
Merge pull request #855 from /issues/854/attr-cache-improvements
6b58457 
Improve file attribute caching
@github-actions github-actions bot mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance improvements or problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve file attribute caching carlspring/s3fs-nio
1 participant
@steve-todorov