Improve file attribute caching #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-todorov
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
steve-todorov
force-pushed
the
issues/854/attr-cache-improvements
branch
from
154d72a to
79d7191
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
steve-todorov
force-pushed
the
issues/854/attr-cache-improvements
branch
2 times, most recently
from
ecb5f5d to
bbcf747
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
steve-todorov
force-pushed
the
issues/854/attr-cache-improvements
branch
from
3d73a1f to
7cc3d79
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/deploy-pr |
StatusSnapshot was successfully deployed! Snapshot artifact coordinates:WARNINGDO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE! |
|
Needs rebasing from |
BREAKING CHANGE: `S3FileSystem#getCache()` method was removed BREAKING CHANGE: `S3Path#setFileAttributes()` was removed. BREAKING CHANGE: `S3FileSystemProvider#getCache()` was removed. BREAKING CHANGE: `S3FileSystemProvider#setCache()` was removed. BREAKING CHANGE: `S3OutputStream` constructor signatures changed
steve-todorov
force-pushed
the
issues/854/attr-cache-improvements
branch
from
e03a486 to
596434b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes #854.
There are some small breaking changes related to some public methods which were removed as logic for the cache has changed:
S3FileSystem#getCache()method was removedS3Path#setFileAttributes()was removed.S3FileSystemProvider#getCache()was removed.S3FileSystemProvider#setCache()was removed.Acceptance Test
gradle clean buildstill works.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?