56 add strata to desk review spreadsheets #80
Conversation
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
There was a problem hiding this comment.
@Damonamajor Per my note on this in-person, you'll also need to modify the template file (misc/desk_review_template.xlsx) and the lines below this to insert the new columns into the Excel workbook.
* Add gaa to eval run_id variable * Hide source code for conditionally included Quarto chunks * Fix code echoed in Quarto doc * Revert default run_id
* Fix missing geography_id for triads * Remove geography_id in mutate()
* Add test * Update reports/performance/_outliers.qmd Co-authored-by: Dan Snow <[email protected]> * lintr --------- Co-authored-by: Dan Snow <[email protected]>
* Replace arrows with equal signs * Revert unload change
* Update params to match residential model * Hide echoed code in model reports * Plot variance wrt time * Update training data * Remove multi-card filter * Update DVC lockfile
Merge branch '2025-assessment-year' of github.com:ccao-data/model-condo-avm into 56-add-strata-to-desk-review-spreadsheets # Conflicts: # renv.lock # reports/_setup.R # reports/performance/_model.qmd
Merge branch '2025-assessment-year' of github.com:ccao-data/model-condo-avm into 56-add-strata-to-desk-review-spreadsheets # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
| char_unit_sf, flag_nonlivable_space, flag_pin10_5yr_num_sale, | ||
| flag_common_area, flag_proration_sum_not_1, flag_pin_is_multiland, | ||
| flag_land_gte_95_percentile, | ||
| char_unit_sf, meta_strata_1, meta_strata_2, flag_nonlivable_space, |
There was a problem hiding this comment.
Flag_common_area was removed
|
@jeancochrane - same NA values occur when running from the 2025-assessment branch. Do we want a new issue to debug that? |
There was a problem hiding this comment.
Awesome work, thanks! A couple tiny formatting nits with the new template -- no need to implement these now, we can clean up all the tiny stuff when we do a final pass for export:
- "Sale Num. Parcels 2" header cell needs a right border in order to close out "Sales Information" section
- Move right border from "Condo Unit S.F." header cell to "Strata 2" in order to close out "Characteristics" section
- Move right border from "YoY Change <= -5%" header cell to "Strata is Imputed" in order to close out "Flags" section
- "Strata is Imputed" header cell needs a hoverable note to explain what it is, similar to the other header cells in the "Flags" section
- "% Change" header cell needs a right border in order to close out "Compared to..." section
pipeline/07-export.R
Outdated
| @@ -80,7 +80,6 @@ land <- dbGetQuery( | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[Question, non-blocking] Is this intentional? Elsewhere in the PR it seems like 4 spaces is the standard between major sections, but I'm not totally sure.
pipeline/07-export.R
Outdated
| @@ -200,7 +200,6 @@ assessment_pin10_prepped <- assessment_pin_prepped %>% | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[Question, non-blocking] Same question here as above.
|
@jeancochrane |
This closes #56 which is the result of creating a flag for imputed strata values and recoding values through this #55.
Reviewing the spreadsheet, it seems as though columns sale_recent_1_sv_added_later through model_org_fmv_pct_chg are NA. This occurs when the spreadsheet is run from the 2025-assessment branch.